[eslint-plugin-exhaustive-deps] Fix exhaustive deps check for unstable vars #24343

afzalsayed96 · 2022-04-11T18:48:27Z

Summary

How did you test this change?

Added 2 test-cases, both valid and invalid.

gaearon · 2022-04-11T18:50:25Z

packages/eslint-plugin-react-hooks/src/ExhaustiveDeps.js

@@ -234,6 +234,9 @@ export default {
            if (id.elements[1] === resolved.identifiers[0]) {
              if (name === 'useState') {
                const references = resolved.references;
+                // console.log(references);


gaearon · 2022-04-11T18:50:36Z

packages/eslint-plugin-react-hooks/src/ExhaustiveDeps.js

@@ -234,6 +234,9 @@ export default {
            if (id.elements[1] === resolved.identifiers[0]) {
              if (name === 'useState') {
                const references = resolved.references;
+                // console.log(references);
+                if (references.filter(ref => ref.isWrite()).length > 1)


Please use curly braces for if statements

sizebot · 2022-04-11T18:53:01Z

Comparing: f993ffc...9152b75

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js	=	131.21 kB	131.21 kB	=	41.98 kB	41.98 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js	=	136.47 kB	136.47 kB	=	43.57 kB	43.57 kB
facebook-www/ReactDOM-prod.classic.js	=	434.63 kB	434.63 kB	=	79.87 kB	79.87 kB
facebook-www/ReactDOM-prod.modern.js	=	419.63 kB	419.63 kB	=	77.50 kB	77.50 kB
facebook-www/ReactDOMForked-prod.classic.js	=	434.63 kB	434.63 kB	=	79.87 kB	79.87 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-experimental/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js	+0.27%	87.43 kB	87.66 kB	+0.20%	20.77 kB	20.81 kB
oss-stable-semver/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js	+0.27%	87.43 kB	87.66 kB	+0.20%	20.77 kB	20.81 kB
oss-stable/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js	+0.27%	87.43 kB	87.66 kB	+0.20%	20.77 kB	20.81 kB

Generated by 🚫 dangerJS against 9152b75

gaearon · 2022-04-11T19:06:22Z

packages/eslint-plugin-react-hooks/src/ExhaustiveDeps.js

@@ -234,6 +234,9 @@ export default {
            if (id.elements[1] === resolved.identifiers[0]) {
              if (name === 'useState') {
                const references = resolved.references;
+                if (references.filter(ref => ref.isWrite()).length > 1) {


This iterates over references but then we iterate over it again in the loop below. Can we just move the check into the loop below?

gaearon · 2022-04-11T20:43:25Z

Thanks!

…le vars (#24343) * Fix exhaustive deps for unstable vars * Fix formatting * Optimise iterations * Fix linting

…le vars (facebook#24343) * Fix exhaustive deps for unstable vars * Fix formatting * Optimise iterations * Fix linting

…le vars (#24343) * Fix exhaustive deps for unstable vars * Fix formatting * Optimise iterations * Fix linting

Summary: This sync includes the following changes: - **[bd4784c8f](facebook/react@bd4784c8f )**: Revert #24236 (Don't recreate the same fallback on the client if hydrating suspends) ([#24434](facebook/react#24434)) //<dan>// - **[6d3b6d0f4](facebook/react@6d3b6d0f4 )**: forwardRef et al shouldn't affect if props reused ([#24421](facebook/react#24421)) //<Andrew Clark>// - **[bd0813766](facebook/react@bd0813766 )**: Fix: useDeferredValue should reuse previous value ([#24413](facebook/react#24413)) //<Andrew Clark>// - **[9ae80d6a2](facebook/react@9ae80d6a2 )**: Suppress hydration warnings when a preceding sibling suspends ([#24404](facebook/react#24404)) //<Josh Story>// - **[0dc4e6663](facebook/react@0dc4e6663 )**: Land enableClientRenderFallbackOnHydrationMismatch ([#24410](facebook/react#24410)) //<Andrew Clark>// - **[354772952](facebook/react@354772952 )**: Land enableSelectiveHydration flag ([#24406](facebook/react#24406)) //<Andrew Clark>// - **[392808a1f](facebook/react@392808a1f )**: Land enableClientRenderFallbackOnTextMismatch flag ([#24405](facebook/react#24405)) //<Andrew Clark>// - **[1e748b452](facebook/react@1e748b452 )**: Land enableLazyElements flag ([#24407](facebook/react#24407)) //<Andrew Clark>// - **[4175f0593](facebook/react@4175f0593 )**: Temporarily feature flag numeric fallback for symbols ([#24401](facebook/react#24401)) //<Ricky>// - **[a6d53f346](facebook/react@a6d53f346 )**: Revert "Clean up Selective Hydration / Event Replay flag ([#24156](facebook/react#24156))" ([#24402](facebook/react#24402)) //<Ricky>// - **[ab9cdd34f](facebook/react@ab9cdd34f )**: Bugfix: In legacy mode, call suspended tree's unmount effects when it is deleted ([#24400](facebook/react#24400)) //<Andrew Clark>// - **[168da8d55](facebook/react@168da8d55 )**: Fix typo that happened during rebasing //<Andrew Clark>// - **[8bc527a4c](facebook/react@8bc527a4c )**: Bugfix: Fix race condition between interleaved and non-interleaved updates ([#24353](facebook/react#24353)) //<Andrew Clark>// - **[f7cf077cc](facebook/react@f7cf077cc )**: [Transition Tracing] Add Offscreen Queue ([#24341](facebook/react#24341)) //<Luna Ruan>// - **[4fc394bbe](facebook/react@4fc394bbe )**: Fix suspense fallback throttling ([#24253](facebook/react#24253)) //<sunderls>// - **[80170a068](facebook/react@80170a068 )**: Match bundle.name and match upper case entry points ([#24346](facebook/react#24346)) //<Sebastian Markbåge>// - **[fea6f8da6](facebook/react@fea6f8da6 )**: [Transition Tracing] Add transition to OffscreenState and pendingSuspenseBoundaries to RootState ([#24340](facebook/react#24340)) //<Luna Ruan>// - **[8e2f9b086](facebook/react@8e2f9b086 )**: move passive flag ([#24339](facebook/react#24339)) //<Luna Ruan>// - **[55a21ef7e](facebook/react@55a21ef7e )**: fix pushTransition for transition tracing ([#24338](facebook/react#24338)) //<Luna Ruan>// - **[069d23bb7](facebook/react@069d23bb7 )**: [eslint-plugin-exhaustive-deps] Fix exhaustive deps check for unstable vars ([#24343](facebook/react#24343)) //<Afzal Sayed>// - **[4997515b9](facebook/react@4997515b9 )**: Point useSubscription to useSyncExternalStore shim ([#24289](facebook/react#24289)) //<dan>// - **[01e2bff1d](facebook/react@01e2bff1d )**: Remove unnecessary check ([#24332](facebook/react#24332)) //<zhoulixiang>// - **[d9a0f9e20](facebook/react@d9a0f9e20 )**: Delete create-subscription folder ([#24288](facebook/react#24288)) //<dan>// - **[f993ffc51](facebook/react@f993ffc51 )**: Fix infinite update loop that happens when an unmemoized value is passed to useDeferredValue ([#24247](facebook/react#24247)) //<Andrew Clark>// - **[fa5800226](facebook/react@fa5800226 )**: [Fizz] Pipeable Stream Perf ([#24291](facebook/react#24291)) //<Josh Story>// - **[0568c0f8c](facebook/react@0568c0f8c )**: Replace zero with NoLanes for consistency in FiberLane ([#24327](facebook/react#24327)) //<Leo>// - **[e0160d50c](facebook/react@e0160d50c )**: add transition tracing transitions stack ([#24321](facebook/react#24321)) //<Luna Ruan>// - **[b0f13e5d3](facebook/react@b0f13e5d3 )**: add pendingPassiveTransitions ([#24320](facebook/react#24320)) //<Luna Ruan>// Changelog: [General][Changed] - React Native sync for revisions 60e63b9...bd4784c jest_e2e[run_all_tests] Reviewed By: kacieb Differential Revision: D35899012 fbshipit-source-id: 86a885e336fca9f0efa80cd2b8ca040f2cb53853

Fix exhaustive deps for unstable vars

7abe1ac

facebook-github-bot added the CLA Signed label Apr 11, 2022

gaearon reviewed Apr 11, 2022

View reviewed changes

Fix formatting

bcf5bea

afzalsayed96 requested a review from gaearon April 11, 2022 19:05

gaearon reviewed Apr 11, 2022

View reviewed changes

afzalsayed96 added 2 commits April 12, 2022 01:00

Optimise iterations

ef66085

Fix linting

9152b75

gaearon merged commit 069d23b into facebook:main Apr 11, 2022

rickhanlonii pushed a commit that referenced this pull request Apr 13, 2022

[eslint-plugin-exhaustive-deps] Fix exhaustive deps check for unstab…

54e7994

…le vars (#24343) * Fix exhaustive deps for unstable vars * Fix formatting * Optimise iterations * Fix linting

rickhanlonii pushed a commit that referenced this pull request Apr 14, 2022

[eslint-plugin-exhaustive-deps] Fix exhaustive deps check for unstab…

959fd2b

…le vars (#24343) * Fix exhaustive deps for unstable vars * Fix formatting * Optimise iterations * Fix linting

zhengjitf pushed a commit to zhengjitf/react that referenced this pull request Apr 15, 2022

[eslint-plugin-exhaustive-deps] Fix exhaustive deps check for unstab…

c05a4d3

…le vars (facebook#24343) * Fix exhaustive deps for unstable vars * Fix formatting * Optimise iterations * Fix linting

rickhanlonii pushed a commit that referenced this pull request Apr 19, 2022

[eslint-plugin-exhaustive-deps] Fix exhaustive deps check for unstab…

cfef6a0

…le vars (#24343) * Fix exhaustive deps for unstable vars * Fix formatting * Optimise iterations * Fix linting

cssecautomation mentioned this pull request Mar 3, 2023

[Snyk] Upgrade: react, react-dom OutSystems/ReactView#126

Open

cssecautomation mentioned this pull request Mar 11, 2023

[Snyk] Upgrade: react, react-dom OutSystems/ReactView#136

Open

This was referenced Feb 10, 2024

[Snyk] Upgrade: react, react-dom stack-spot/web-react-appshell-template#4

Open

[Snyk] Upgrade: react, react-dom stack-spot/web-nextjs-template#5

Open

mnathsnyk mentioned this pull request May 15, 2024

[Snyk] Upgrade: react, react-dom mnathsnyk/AWSGoat#1

Open

NOUIY mentioned this pull request May 18, 2024

[Snyk] Upgrade: react, react-dom NOUIY/swr#171

Open

This was referenced Nov 2, 2024

[Snyk] Upgrade react from 17.0.2 to 18.3.1 jakejack13/JayJay-Star#9

Merged

[Snyk] Upgrade react-dom from 17.0.2 to 18.3.1 jakejack13/JayJay-Star#10

Closed

This was referenced Nov 4, 2024

[Snyk] Upgrade react-dom from 18.0.0 to 18.3.1 Exkaleburx/bitcore#1127

Open

[Snyk] Upgrade react from 18.1.0 to 18.3.1 Exkaleburx/bitcore#1128

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[eslint-plugin-exhaustive-deps] Fix exhaustive deps check for unstable vars #24343

[eslint-plugin-exhaustive-deps] Fix exhaustive deps check for unstable vars #24343

afzalsayed96 commented Apr 11, 2022

gaearon Apr 11, 2022

gaearon Apr 11, 2022

sizebot commented Apr 11, 2022 •

edited

Loading

gaearon Apr 11, 2022

afzalsayed96 Apr 11, 2022

gaearon commented Apr 11, 2022

[eslint-plugin-exhaustive-deps] Fix exhaustive deps check for unstable vars #24343

[eslint-plugin-exhaustive-deps] Fix exhaustive deps check for unstable vars #24343

Conversation

afzalsayed96 commented Apr 11, 2022

Summary

How did you test this change?

gaearon Apr 11, 2022

Choose a reason for hiding this comment

gaearon Apr 11, 2022

Choose a reason for hiding this comment

sizebot commented Apr 11, 2022 • edited Loading

Critical size changes

Significant size changes

gaearon Apr 11, 2022

Choose a reason for hiding this comment

afzalsayed96 Apr 11, 2022

Choose a reason for hiding this comment

gaearon commented Apr 11, 2022

sizebot commented Apr 11, 2022 •

edited

Loading