Fix suspense fallback throttling #24253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Comparing: e0160d5...8bd48ca Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
sunderls
commented
Apr 1, 2022
sunderls
force-pushed
the
fix-suspense-throttling
branch
from
fd70a75
to
d9a9e7c
Compare
sunderls
force-pushed
the
fix-suspense-throttling
branch
2 times, most recently
from
d45bb57
to
9805935
Compare
|
It would be nice to add some test that passes in this branch but fails on main. |
|
Nice fix! I can work on adding a test unless you beat me to it |
sunderls
force-pushed
the
fix-suspense-throttling
branch
from
9805935
to
a2bfae1
Compare
sunderls
force-pushed
the
fix-suspense-throttling
branch
from
a2bfae1
to
b1062aa
Compare
sunderls
force-pushed
the
fix-suspense-throttling
branch
from
345b90f
to
d89c871
Compare
gaearon
changed the title
|
@sunderls Thank you so much for finding this and sending a fix! Really nice work. |
|
Very impressive PR! Thanks for the fix! |
rickhanlonii
pushed a commit
that referenced
this pull request
Apr 13, 2022
* fix suspense throttling * fix lint * Tweak tests + another test Co-authored-by: Dan Abramov <[email protected]>
rickhanlonii
pushed a commit
that referenced
this pull request
Apr 14, 2022
* fix suspense throttling * fix lint * Tweak tests + another test Co-authored-by: Dan Abramov <[email protected]>
zhengjitf
pushed a commit
to zhengjitf/react
that referenced
this pull request
Apr 15, 2022
* fix suspense throttling * fix lint * Tweak tests + another test Co-authored-by: Dan Abramov <[email protected]>
rickhanlonii
pushed a commit
that referenced
this pull request
Apr 19, 2022
* fix suspense throttling * fix lint * Tweak tests + another test Co-authored-by: Dan Abramov <[email protected]>
This was referenced Nov 1, 2024
This was referenced Nov 2, 2024
This was referenced Nov 2, 2024
This was referenced Nov 4, 2024
This was referenced Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There seems to be a regression on suspense throttling.
in React 18-alpha version, Suspense fallbacks are throttled in committing codesandbox link
in React 18 release version, this is no longer working codesandbox link
Root cause
see the inline comments
How did you test this change?
Apr-02-2022.00-24-42.mp4
Apr-02-2022.00-25-25.mp4
Test
Added one more test case in
ReactSuspense-test.internal.js, to mimic the repro in above videoson
mainbranch it failsin this patch, it passes