Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Unexpected debugger statement in DevTools (solved) #19308

Closed
eiamei opened this issue Jul 10, 2020 · 16 comments · Fixed by #19309
Closed

Bug: Unexpected debugger statement in DevTools (solved) #19308

eiamei opened this issue Jul 10, 2020 · 16 comments · Fixed by #19309

Comments

@eiamei
Copy link

eiamei commented Jul 10, 2020

Looks like you forgot about the debugger inside the react_devtools_backend.js.

React dev tools version: 4.8.0

Steps To Reproduce

  1. Update (or install) the latest version of devtools
  2. Open devtools
  3. The code will be stopped on the debugger inside react_devtools_backend.js

IMAGE 2020-07-10 13:43:52

The current behavior

If I open devtools with react dev tools extension it will stop every time on debugger inside react_devtools_backend.js

The expected behavior

It doesn't seem like it should be happening 😃

@eiamei eiamei added the Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug label Jul 10, 2020
@JakubRimal
Copy link

Same here, I've had to disable the extension because of this... 😄

@martinhorsky
Copy link

Same for me.

@gaearon gaearon added Component: Developer Tools Type: Bug and removed Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug labels Jul 10, 2020
@gaearon
Copy link
Collaborator

gaearon commented Jul 10, 2020

Looks bad.

@antislash21
Copy link

Same here

@Lukortech
Copy link

That's the guy you're looking for :D

@gaearon
Copy link
Collaborator

gaearon commented Jul 10, 2020

Yes, but see the comment above it. :-) It is intentional, but this option should have been off by default.

@przemuh
Copy link

przemuh commented Jul 10, 2020

As a temporary solution you can "blackbox" script in Chrome Dev Tools:

image

@gaearon
Copy link
Collaborator

gaearon commented Jul 10, 2020

You should also be able to go to Components tab, press Settings gear, add checkbox to Break on Warning, then do this again, and remove the checkbox as a temporary workaround.

@gaearon
Copy link
Collaborator

gaearon commented Jul 10, 2020

I'll keep it open until we cut a release

@gaearon gaearon reopened this Jul 10, 2020
@eiamei
Copy link
Author

eiamei commented Jul 10, 2020

Thanks 🙌

@gaearon
Copy link
Collaborator

gaearon commented Jul 10, 2020

I've submitted a fix to Chrome addons. It should appear there in a few hours. If it doesn't work after updating to 4.8.1, try to clear your local storage (localStorage.clear()).

I can't figure out how to submit it to FF store because something in our process has changed. So @bvaughn will be able to help us out there when he wakes up. :-)

@gaearon
Copy link
Collaborator

gaearon commented Jul 10, 2020

Here's a step-by-step instruction for how to work around it while the fix is pending review:

  1. Press the Settings gear icon in the upper right corner

Screenshot 2020-07-10 at 14 39 06

  1. Open the Debugging tab

Screenshot 2020-07-10 at 14 39 13

  1. Put the checkmark next to Break on Warnings

Screenshot 2020-07-10 at 14 39 20

  1. Remove the checkmark next to Break on Warnings

Screenshot 2020-07-10 at 14 39 25

Now reload the page and you shouldn't be bothered by it.

@gaearon
Copy link
Collaborator

gaearon commented Jul 10, 2020

Please refrain from "same" comments unless you have something new to say. They are not helpful and obscure the workaround (#19308 (comment)).

@bvaughn
Copy link
Contributor

bvaughn commented Jul 10, 2020

Update:

  • The fix has been published to NPM as 4.81
  • The updated extension (with fix) is live for Firefox
  • The updated extension is pending for Chrome
  • Edge is still providing the previous version 4.7 (but an updated 4.8.1 is also pending for review)

@bvaughn
Copy link
Contributor

bvaughn commented Jul 10, 2020

We'll keep this issue open until the fix has been deployed on Chrome, but I'm going to lock it to prevent +1 😄

@facebook facebook locked as resolved and limited conversation to collaborators Jul 10, 2020
@bvaughn bvaughn changed the title Bug: forgot to remove the debugger in the last release of the dev tools. Bug: Unexpected debugger statement in DevTools (solved) Jul 10, 2020
@bvaughn
Copy link
Contributor

bvaughn commented Jul 11, 2020

4.8.1 is live in Chrome store now too, so I'm going to close this.

@bvaughn bvaughn closed this as completed Jul 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants