Bug: debugger getting triggered on warnings (but setting not enabled)

[mrcoles]

React version: 16.9.5

Steps To Reproduce

1. Open the dev console in Firefox (78.0.1) that is running React Developer Tools (from revision a5b4492 on 7/9/2020)
2. Don’t change any settings from the defaults
3. Do something that triggers a warning, like running stripe.js in test mode on http
4. The debugger gets triggered even though “Trigger on warn” is not set and neither is debugger on exceptions in the console settings

(see screenshots at bottom)

The current behavior

The debugger gets triggered

The expected behavior

The debugger should not get triggered

Workaround

Refreshing the page did nothing.

I toggled the value on, closed the dialog, opened it again and toggled it off. That fixed it for me.

Screenshots

[runofthemillgeek]

Happening to me as well on FF 79.0b5 (Dev Edition) with React DevTools 4.8.0-a5b449295.

I'm guessing the following is the reason? Shouldn't this be return false at the end for the default return value?

react/packages/react-devtools-shared/src/utils.js

Lines 252 to 262 in 14084be

	export function getBreakOnConsoleErrors(): boolean {
	try {
	const raw = localStorageGetItem(
	LOCAL_STORAGE_SHOULD_BREAK_ON_CONSOLE_ERRORS,
	);
	if (raw != null) {
	return JSON.parse(raw);
	}
	} catch (error) {}
	return true;
	}

[zmyjs]

I also faced this problem.

Firefox React DevTools v4.8.0

[kotoshii]

Same thing
FF, React DevTools 4.8.0

[gaearon]

As a temporary workaround, try setting this setting to true, closing the window, and then setting it back to false. We're tracking this in #19308 but I can't figure out how to update the FF addon (the store doesn't show any) so we'll need to wait for @bvaughn's help. I'm closing so we consolidate the discussion in #19308.