hermes-engine should build with target Java version 17 (#51162)

cortinico · facebook-github-bot · commit db18aac521d2 · 2025-05-08T03:17:16.000-07:00
Summary: Pull Request resolved: #51162 We specify the java target version to 17 for ReactAndroid but not for hermes-engine. This is causing it to be the default (8) which will cause our build to fail on JDK 21. This fixes it. Changelog: [Internal] [Changed] - Reviewed By: alanleedev Differential Revision: D74325107 fbshipit-source-id: 39ba745be4fa754fb0b0408160202940a61fcd94
diff --git a/packages/react-native/ReactAndroid/hermes-engine/build.gradle.kts b/packages/react-native/ReactAndroid/hermes-engine/build.gradle.kts
@@ -250,6 +250,11 @@ android {
       }
     }
     ndk { abiFilters.addAll(reactNativeArchitectures()) }
+
+    compileOptions {
+      sourceCompatibility = JavaVersion.VERSION_17
+      targetCompatibility = JavaVersion.VERSION_17
+    }
   }
 
   externalNativeBuild {

Original file line number	Diff line number	Diff line change
`@@ -250,6 +250,11 @@ android {`
`250`	`250`	`}`
`251`	`251`	`}`
`252`	`252`	`ndk { abiFilters.addAll(reactNativeArchitectures()) }`
	`253`	`+`
	`254`	`+ compileOptions {`
	`255`	`+ sourceCompatibility = JavaVersion.VERSION_17`
	`256`	`+ targetCompatibility = JavaVersion.VERSION_17`
	`257`	`+ }`
`253`	`258`	`}`
`254`	`259`
`255`	`260`	`externalNativeBuild {`