Fix default accessor for unstable_fuseboxEnabled (RNTester crash) #44926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D58527490
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D58527490 |
Base commit: 3cb03cb |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 14, 2024
Summary: With the migration to GHA, we are updating the testing scripts to work with the new CI. There are a bit of shenanigans due to: * How GHA archives artifacts => they are all `.zip` files, so I had to play around with unzipping them * GHA seems to create a different commit, like if it is forking the repo instead of using it. I think that it is how the checkout action works. *Note:* this might be a problem for the `Create React Native Release` workflow because it has to commit on the stable branch! * Android is building only the simulator architecture when running from regular CI. The app is not configured to run only on that, so the RNTestProject was a failing because it was trying to build all the available architectures. It is an easy fix in the user project space when release testing. ## Changelog: [Internal] - Update the testing script to work with the new CI Pull Request resolved: #44923 Test Plan: Tested locally. * [iOS] RNTester - Hermes ✅ * [iOS] RNTester - JSC ✅ * [Android] RNTester - Hermes ✅ * [Android] RNTester - JSC ✅ * [iOS] RNTestProject - Hermes ✅ (The project is created correctly and it builds, crash at runtime for #44926) * [iOS] RNTestProject - JSC ✅ (The project is created correctly and it builds, crash at runtime for #44926) * [Android] RNTester - Hermes ✅ (Needed to build only the simulator architecture) * [Android] RNTester - JSC ✅ (Needed to build only the simulator architecture) Reviewed By: andrewdacenko Differential Revision: D58528432 Pulled By: cipolleschi fbshipit-source-id: 733065de4c532b13d8e95e2217f9aafd5a2ef8a0
|
Committed in 1c6bf24 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Changelog: [Internal]
Reviewed By: cipolleschi
Differential Revision: D58527490