Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RN][CI]Update the testing-script to use github actions #44923

Closed
wants to merge 1 commit into from

Conversation

cipolleschi
Copy link
Contributor

@cipolleschi cipolleschi commented Jun 13, 2024

Summary:

With the migration to GHA, we are updating the testing scripts to work with the new CI.

There are a bit of shenanigans due to:

  • How GHA archives artifacts => they are all .zip files, so I had to play around with unzipping them
  • GHA seems to create a different commit, like if it is forking the repo instead of using it. I think that it is how the checkout action works. Note: this might be a problem for the Create React Native Release workflow because it has to commit on the stable branch!
  • Android is building only the simulator architecture when running from regular CI. The app is not configured to run only on that, so the RNTestProject was a failing because it was trying to build all the available architectures. It is an easy fix in the user project space when release testing.

Changelog:

[Internal] - Update the testing script to work with the new CI

Test Plan:

Tested locally.

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Jun 13, 2024
@cipolleschi cipolleschi force-pushed the cipolleschi/migrate-release-testing-to-gha branch from 5ad1e44 to 54bb605 Compare June 13, 2024 08:35
@analysis-bot
Copy link

analysis-bot commented Jun 13, 2024

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 20,365,505 -54
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 23,569,563 -60
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: e78742a
Branch: main

@cipolleschi cipolleschi force-pushed the cipolleschi/migrate-release-testing-to-gha branch 5 times, most recently from 6c6551e to ae57dee Compare June 13, 2024 14:34
@cipolleschi cipolleschi marked this pull request as ready for review June 13, 2024 14:35
@cipolleschi cipolleschi force-pushed the cipolleschi/migrate-release-testing-to-gha branch from ae57dee to ddb69d6 Compare June 13, 2024 14:35
@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cipolleschi cipolleschi force-pushed the cipolleschi/migrate-release-testing-to-gha branch from ddb69d6 to d26b899 Compare June 14, 2024 16:37
@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jun 14, 2024
@facebook-github-bot
Copy link
Contributor

@cipolleschi merged this pull request in f1a362d.

Copy link

This pull request was successfully merged by @cipolleschi in f1a362d.

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants