Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid static_pointer_cast in GenerateModuleH.js #44889

Closed
wants to merge 1 commit into from
Closed

Avoid static_pointer_cast in GenerateModuleH.js #44889

wants to merge 1 commit into from
+2 −2

Commits on Jun 12, 2024

  1. Avoid static_pointer_cast in GenerateModuleH.js (facebook#44889) 

    Summary:
Pull Request resolved: facebook#44889

Avoid static_pointer_cast. It provides no type-safety, and requires increasing the shared_ptr

## Changelog:

[Internal] [Fixed] - Avoid static_pointer_cast in GenerateModuleH.js

Reviewed By: javache

Differential Revision: D58449748
    @christophpurrer @facebook-github-bot
    christophpurrer authored and facebook-github-bot committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    28e4c0a View commit details
    Browse the repository at this point in the history