Avoid static_pointer_cast in GenerateModuleH.js #44889
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D58449748 |
Base commit: 6a3a305 |
|
This pull request was exported from Phabricator. Differential Revision: D58449748 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jun 12, 2024
Summary: Pull Request resolved: facebook#44889 Avoid static_pointer_cast. It provides no type-safety, and requires increasing the shared_ptr ## Changelog: [Internal] [Fixed] - Avoid static_pointer_cast in GenerateModuleH.js Differential Revision: D58449748
christophpurrer
force-pushed
the
export-D58449748
branch
from
1ff0823
to
9e0477a
Compare
Summary: Pull Request resolved: facebook#44889 Avoid static_pointer_cast. It provides no type-safety, and requires increasing the shared_ptr ## Changelog: [Internal] [Fixed] - Avoid static_pointer_cast in GenerateModuleH.js Reviewed By: javache Differential Revision: D58449748
|
This pull request was exported from Phabricator. Differential Revision: D58449748 |
christophpurrer
force-pushed
the
export-D58449748
branch
from
9e0477a
to
28e4c0a
Compare
|
This pull request has been merged in c5d380f. |
|
This pull request was successfully merged by @christophpurrer in c5d380f. When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Avoid static_pointer_cast. It provides no type-safety, and requires increasing the shared_ptr
Changelog:
[Internal] [Fixed] - Avoid static_pointer_cast in GenerateModuleH.js
Differential Revision: D58449748