Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent Fusebox infra crash if RCTBridge is dealloc'ed off the main queue #44877

Closed
wants to merge 1 commit into from
Closed

Prevent Fusebox infra crash if RCTBridge is dealloc'ed off the main queue #44877

wants to merge 1 commit into from

Commits on Jun 12, 2024

  1. Prevent Fusebox infra crash if RCTBridge is dealloc'ed off the main q… 

    …ueue (facebook#44877)

Summary:
Pull Request resolved: facebook#44877

Changelog: [Internal]

We're seeing a sporadic iOS crash that suggests `[RCTBridge dealloc]` is being called off the main queue (despite a comment suggesting it shouldn't be). This exposes a race condition between destroying the `HostTarget` and attempting to unregister the instance+runtime from it . Here we use `RCTExecuteOnMainQueue` to make sure the `HostTarget` destruction is always sequenced after the `unregisterFromInspector()` call.

Reviewed By: huntie

Differential Revision: D58415684
    @motiz88 @facebook-github-bot
    motiz88 authored and facebook-github-bot committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    f049bec View commit details
    Browse the repository at this point in the history