Prevent Fusebox infra crash if RCTBridge is dealloc'ed off the main queue #44877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D58415684 |
|
This pull request was exported from Phabricator. Differential Revision: D58415684 |
motiz88
force-pushed
the
export-D58415684
branch
from
317ff78
to
3fab0d1
Compare
motiz88
added a commit
to motiz88/react-native
that referenced
this pull request
Jun 12, 2024
…ueue (facebook#44877) Summary: Pull Request resolved: facebook#44877 Changelog: [Internal] We're seeing a sporadic iOS crash that suggests `[RCTBridge dealloc]` is being called off the main queue (despite a comment suggesting it shouldn't be). This exposes a race condition between destroying the `HostTarget` and attempting to unregister the instance+runtime from it . Here we use `RCTExecuteOnMainQueue` to make sure the `HostTarget` destruction is always sequenced after the `unregisterFromInspector()` call. Differential Revision: D58415684
…ueue (facebook#44877) Summary: Pull Request resolved: facebook#44877 Changelog: [Internal] We're seeing a sporadic iOS crash that suggests `[RCTBridge dealloc]` is being called off the main queue (despite a comment suggesting it shouldn't be). This exposes a race condition between destroying the `HostTarget` and attempting to unregister the instance+runtime from it . Here we use `RCTExecuteOnMainQueue` to make sure the `HostTarget` destruction is always sequenced after the `unregisterFromInspector()` call. Reviewed By: huntie Differential Revision: D58415684
|
This pull request was exported from Phabricator. Differential Revision: D58415684 |
motiz88
force-pushed
the
export-D58415684
branch
from
3fab0d1
to
f049bec
Compare
|
This pull request has been merged in df35e25. |
|
This pull request was successfully merged by @motiz88 in df35e25. When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
We're seeing a sporadic iOS crash that suggests
[RCTBridge dealloc]is being called off the main queue (despite a comment suggesting it shouldn't be). This exposes a race condition between destroying theHostTargetand attempting to unregister the instance+runtime from it . Here we useRCTExecuteOnMainQueueto make sure theHostTargetdestruction is always sequenced after theunregisterFromInspector()call.Differential Revision: D58415684