Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration RN Alert Dialog to androidx #44495

Closed
wants to merge 2 commits into from
Closed

Migration RN Alert Dialog to androidx #44495

wants to merge 2 commits into from

Commits on Jun 11, 2024

  1. Migration RN Alert Dialog to androidx 

    Summary:
Migrates the `AlertFragment` from `android.app.AlertDialog` to `androidx.appcompat.app.AlertDialog`. This backports tons of fixes that have gone into the AlertDialog component over the years, including proper line wrapping of button text, alignment of buttons, etc.

## For consideration
- Alert dialog themes may no longer need the `android` namespace, meaning themes can now be specified as `alertDialogTheme` rather than `android:alertDialogTheme`.
- This change requires all implementing activities to have a theme that inherits from `Theme.AppCompat`. Creation of any activities which do not have a descendant of this style will result in an `IllegalStateException`: https://www.internalfb.com/intern/signalinfra/exception_owners/?mid=5ee93f6ecd59f3d8ad82a78c213ea016&result_id=16044073705339118.281475102518721.1715097866

Differential Revision: D57019423
    @Abbondanzo @facebook-github-bot
    Abbondanzo authored and facebook-github-bot committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    dd52aab View commit details
    Browse the repository at this point in the history

  2. Fall back to app AlertDialog for non AppCompat themes (facebook#44495) 

    Summary:
Pull Request resolved: facebook#44495

## Summary
Migrates the `AlertFragment` from `android.app.AlertDialog` to `androidx.appcompat.app.AlertDialog`. This backports tons of fixes that have gone into the AlertDialog component over the years, including proper line wrapping of button text, dark mode support, alignment of buttons, etc.

This change provides a fallback to the original `android.app.AlertDialog` if the current activity is not an AppCompat descendant.

## For consideration
- Alert dialog themes may no longer need the `android` namespace, meaning themes can now be specified as `alertDialogTheme` rather than `android:alertDialogTheme`.

## Changelog:

[Android] [Changed] - Migrated `AlertFragment` dialog builder to use `androidx.appcompat`

Reviewed By: zeyap

Differential Revision: D57113950
    @Abbondanzo @facebook-github-bot
    Abbondanzo authored and facebook-github-bot committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    70067f3 View commit details
    Browse the repository at this point in the history