New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration RN Alert Dialog to androidx #44495

Closed

Abbondanzo wants to merge 2 commits into facebook:main from Abbondanzo:export-D57113950

Contributor

Abbondanzo commented May 8, 2024 •

edited

Loading

Summary

Migrates the AlertFragment from android.app.AlertDialog to androidx.appcompat.app.AlertDialog. This backports tons of fixes that have gone into the AlertDialog component over the years, including proper line wrapping of button text, dark mode support, alignment of buttons, etc.

This change provides a fallback to the original android.app.AlertDialog if the current activity is not an AppCompat descendant.

For consideration

Alert dialog themes may no longer need the android namespace, meaning themes can now be specified as alertDialogTheme rather than android:alertDialogTheme.

Changelog:

[Android] [Changed] - Migrated AlertDialog to androidx.appcompat

Differential Revision: D57019423 and D57113950

facebook-github-bot added CLA Signed p: Facebook Partner labels

Contributor

facebook-github-bot commented May 8, 2024

This pull request was exported from Phabricator. Differential Revision: D57113950

facebook-github-bot added the fb-exported label

Abbondanzo mentioned this pull request

Migration RN Alert Dialog to androidx #44494

Closed

Abbondanzo changed the title ~~Provide fallback for new AlertDialog~~ Migration RN Alert Dialog to androidx

Abbondanzo mentioned this pull request

Add proposal for migrating AlertDialog react-native-community/discussions-and-proposals#784

Open

Contributor

facebook-github-bot commented May 8, 2024

This pull request was exported from Phabricator. Differential Revision: D57113950

Abbondanzo force-pushed the export-D57113950 branch from bb49ded to bd26c31 Compare

May 8, 2024 17:43

analysis-bot commented May 8, 2024 •

edited

Loading

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	20,249,243	-5
android	hermes	armeabi-v7a	n/a	--
android	hermes	x86	n/a	--
android	hermes	x86_64	n/a	--
android	jsc	arm64-v8a	23,454,742	-8
android	jsc	armeabi-v7a	n/a	--
android	jsc	x86	n/a	--
android	jsc	x86_64	n/a	--

Base commit: 8a15e0d
Branch: main

Abbondanzo added a commit to Abbondanzo/react-native that referenced this pull request


          Migration RN Alert Dialog to androidx (facebook#44495)

5d9a947

Summary:

## Summary
Migrates the `AlertFragment` from `android.app.AlertDialog` to `androidx.appcompat.app.AlertDialog`. This backports tons of fixes that have gone into the AlertDialog component over the years, including proper line wrapping of button text, dark mode support, alignment of buttons, etc.

This change provides a fallback to the original `android.app.AlertDialog` if the current activity is not an AppCompat descendant.

## For consideration
- Alert dialog themes may no longer need the `android` namespace, meaning themes can now be specified as `alertDialogTheme` rather than `android:alertDialogTheme`.

## Changelog:

[Android] [Changed] - Migrated `AlertFragment` dialog builder to use `androidx.appcompat`

Differential Revision: D57113950

Abbondanzo force-pushed the export-D57113950 branch from bd26c31 to 5d9a947 Compare

May 9, 2024 15:44

Contributor

facebook-github-bot commented May 9, 2024

This pull request was exported from Phabricator. Differential Revision: D57113950

1 similar comment

Contributor

facebook-github-bot commented May 10, 2024

This pull request was exported from Phabricator. Differential Revision: D57113950

Abbondanzo force-pushed the export-D57113950 branch from 5d9a947 to fef8690 Compare

May 10, 2024 16:21

Abbondanzo added a commit to Abbondanzo/react-native that referenced this pull request


          Fall back to app AlertDialog for non AppCompat themes (facebook#44495)

fef8690

Summary:
Pull Request resolved: facebook#44495

## Summary
Migrates the `AlertFragment` from `android.app.AlertDialog` to `androidx.appcompat.app.AlertDialog`. This backports tons of fixes that have gone into the AlertDialog component over the years, including proper line wrapping of button text, dark mode support, alignment of buttons, etc.

This change provides a fallback to the original `android.app.AlertDialog` if the current activity is not an AppCompat descendant.

## For consideration
- Alert dialog themes may no longer need the `android` namespace, meaning themes can now be specified as `alertDialogTheme` rather than `android:alertDialogTheme`.

## Changelog:

[Android] [Changed] - Migrated `AlertFragment` dialog builder to use `androidx.appcompat`

Reviewed By: zeyap

Differential Revision: D57113950

Contributor

facebook-github-bot commented May 10, 2024

This pull request was exported from Phabricator. Differential Revision: D57113950

Abbondanzo added a commit to Abbondanzo/react-native that referenced this pull request


          Fall back to app AlertDialog for non AppCompat themes (facebook#44495)

44df6df

Summary:
Pull Request resolved: facebook#44495

## Summary
Migrates the `AlertFragment` from `android.app.AlertDialog` to `androidx.appcompat.app.AlertDialog`. This backports tons of fixes that have gone into the AlertDialog component over the years, including proper line wrapping of button text, dark mode support, alignment of buttons, etc.

This change provides a fallback to the original `android.app.AlertDialog` if the current activity is not an AppCompat descendant.

## For consideration
- Alert dialog themes may no longer need the `android` namespace, meaning themes can now be specified as `alertDialogTheme` rather than `android:alertDialogTheme`.

## Changelog:

[Android] [Changed] - Migrated `AlertFragment` dialog builder to use `androidx.appcompat`

Reviewed By: zeyap

Differential Revision: D57113950

Abbondanzo force-pushed the export-D57113950 branch from fef8690 to 44df6df Compare

May 10, 2024 18:17

Contributor

facebook-github-bot commented May 13, 2024

This pull request was exported from Phabricator. Differential Revision: D57113950

Abbondanzo force-pushed the export-D57113950 branch from 44df6df to ca51a4b Compare

May 13, 2024 20:35

Abbondanzo added a commit to Abbondanzo/react-native that referenced this pull request


          Fall back to app AlertDialog for non AppCompat themes (facebook#44495)

ca51a4b

Summary:
Pull Request resolved: facebook#44495

## Summary
Migrates the `AlertFragment` from `android.app.AlertDialog` to `androidx.appcompat.app.AlertDialog`. This backports tons of fixes that have gone into the AlertDialog component over the years, including proper line wrapping of button text, dark mode support, alignment of buttons, etc.

This change provides a fallback to the original `android.app.AlertDialog` if the current activity is not an AppCompat descendant.

## For consideration
- Alert dialog themes may no longer need the `android` namespace, meaning themes can now be specified as `alertDialogTheme` rather than `android:alertDialogTheme`.

## Changelog:

[Android] [Changed] - Migrated `AlertFragment` dialog builder to use `androidx.appcompat`

Reviewed By: zeyap

Differential Revision: D57113950

Abbondanzo force-pushed the export-D57113950 branch from ca51a4b to e576765 Compare

May 23, 2024 13:11

Abbondanzo added a commit to Abbondanzo/react-native that referenced this pull request


          Fall back to app AlertDialog for non AppCompat themes (facebook#44495)

e576765

Summary:

## Summary
Migrates the `AlertFragment` from `android.app.AlertDialog` to `androidx.appcompat.app.AlertDialog`. This backports tons of fixes that have gone into the AlertDialog component over the years, including proper line wrapping of button text, dark mode support, alignment of buttons, etc.

This change provides a fallback to the original `android.app.AlertDialog` if the current activity is not an AppCompat descendant.

## For consideration
- Alert dialog themes may no longer need the `android` namespace, meaning themes can now be specified as `alertDialogTheme` rather than `android:alertDialogTheme`.

## Changelog:

[Android] [Changed] - Migrated `AlertFragment` dialog builder to use `androidx.appcompat`

Reviewed By: zeyap

Differential Revision: D57113950

Contributor

facebook-github-bot commented May 23, 2024

This pull request was exported from Phabricator. Differential Revision: D57113950

Abbondanzo added a commit to Abbondanzo/react-native that referenced this pull request


          Fall back to app AlertDialog for non AppCompat themes (facebook#44495)

004b517

Summary:

## Summary
Migrates the `AlertFragment` from `android.app.AlertDialog` to `androidx.appcompat.app.AlertDialog`. This backports tons of fixes that have gone into the AlertDialog component over the years, including proper line wrapping of button text, dark mode support, alignment of buttons, etc.

This change provides a fallback to the original `android.app.AlertDialog` if the current activity is not an AppCompat descendant.

## For consideration
- Alert dialog themes may no longer need the `android` namespace, meaning themes can now be specified as `alertDialogTheme` rather than `android:alertDialogTheme`.

## Changelog:

[Android] [Changed] - Migrated `AlertFragment` dialog builder to use `androidx.appcompat`

Reviewed By: zeyap

Differential Revision: D57113950

Abbondanzo force-pushed the export-D57113950 branch from e576765 to 004b517 Compare

June 6, 2024 15:11

Contributor

facebook-github-bot commented Jun 6, 2024

This pull request was exported from Phabricator. Differential Revision: D57113950

1 similar comment

Contributor

facebook-github-bot commented Jun 10, 2024

This pull request was exported from Phabricator. Differential Revision: D57113950

Abbondanzo force-pushed the export-D57113950 branch from 004b517 to 9036508 Compare

June 10, 2024 16:53

Abbondanzo added a commit to Abbondanzo/react-native that referenced this pull request


          Fall back to app AlertDialog for non AppCompat themes (facebook#44495)

Summary:
Pull Request resolved: facebook#44495

## Summary
Migrates the `AlertFragment` from `android.app.AlertDialog` to `androidx.appcompat.app.AlertDialog`. This backports tons of fixes that have gone into the AlertDialog component over the years, including proper line wrapping of button text, dark mode support, alignment of buttons, etc.

This change provides a fallback to the original `android.app.AlertDialog` if the current activity is not an AppCompat descendant.

## For consideration
- Alert dialog themes may no longer need the `android` namespace, meaning themes can now be specified as `alertDialogTheme` rather than `android:alertDialogTheme`.

## Changelog:

[Android] [Changed] - Migrated `AlertFragment` dialog builder to use `androidx.appcompat`

Reviewed By: zeyap

Differential Revision: D57113950

Contributor

facebook-github-bot commented Jun 10, 2024

This pull request was exported from Phabricator. Differential Revision: D57113950

Abbondanzo added a commit to Abbondanzo/react-native that referenced this pull request


          Fall back to app AlertDialog for non AppCompat themes (facebook#44495)

80e43ab

Summary:
Pull Request resolved: facebook#44495

## Summary
Migrates the `AlertFragment` from `android.app.AlertDialog` to `androidx.appcompat.app.AlertDialog`. This backports tons of fixes that have gone into the AlertDialog component over the years, including proper line wrapping of button text, dark mode support, alignment of buttons, etc.

This change provides a fallback to the original `android.app.AlertDialog` if the current activity is not an AppCompat descendant.

## For consideration
- Alert dialog themes may no longer need the `android` namespace, meaning themes can now be specified as `alertDialogTheme` rather than `android:alertDialogTheme`.

## Changelog:

[Android] [Changed] - Migrated `AlertFragment` dialog builder to use `androidx.appcompat`

Reviewed By: zeyap

Differential Revision: D57113950

Abbondanzo force-pushed the export-D57113950 branch from 9036508 to 80e43ab Compare

June 10, 2024 20:13

Contributor

facebook-github-bot commented Jun 11, 2024

This pull request was exported from Phabricator. Differential Revision: D57113950

Abbondanzo force-pushed the export-D57113950 branch from 80e43ab to 748404f Compare

June 11, 2024 13:57

Abbondanzo added a commit to Abbondanzo/react-native that referenced this pull request


          Fall back to app AlertDialog for non AppCompat themes (facebook#44495)

748404f

Summary:
Pull Request resolved: facebook#44495

## Summary
Migrates the `AlertFragment` from `android.app.AlertDialog` to `androidx.appcompat.app.AlertDialog`. This backports tons of fixes that have gone into the AlertDialog component over the years, including proper line wrapping of button text, dark mode support, alignment of buttons, etc.

This change provides a fallback to the original `android.app.AlertDialog` if the current activity is not an AppCompat descendant.

## For consideration
- Alert dialog themes may no longer need the `android` namespace, meaning themes can now be specified as `alertDialogTheme` rather than `android:alertDialogTheme`.

## Changelog:

[Android] [Changed] - Migrated `AlertFragment` dialog builder to use `androidx.appcompat`

Reviewed By: zeyap

Differential Revision: D57113950

Abbondanzo added 2 commits

June 11, 2024 11:33


          Migration RN Alert Dialog to androidx

dd52aab

Summary:
Migrates the `AlertFragment` from `android.app.AlertDialog` to `androidx.appcompat.app.AlertDialog`. This backports tons of fixes that have gone into the AlertDialog component over the years, including proper line wrapping of button text, alignment of buttons, etc.

## For consideration
- Alert dialog themes may no longer need the `android` namespace, meaning themes can now be specified as `alertDialogTheme` rather than `android:alertDialogTheme`.
- This change requires all implementing activities to have a theme that inherits from `Theme.AppCompat`. Creation of any activities which do not have a descendant of this style will result in an `IllegalStateException`: https://www.internalfb.com/intern/signalinfra/exception_owners/?mid=5ee93f6ecd59f3d8ad82a78c213ea016&result_id=16044073705339118.281475102518721.1715097866

Differential Revision: D57019423


          Fall back to app AlertDialog for non AppCompat themes (facebook#44495)

70067f3

Summary:
Pull Request resolved: facebook#44495

## Summary
Migrates the `AlertFragment` from `android.app.AlertDialog` to `androidx.appcompat.app.AlertDialog`. This backports tons of fixes that have gone into the AlertDialog component over the years, including proper line wrapping of button text, dark mode support, alignment of buttons, etc.

This change provides a fallback to the original `android.app.AlertDialog` if the current activity is not an AppCompat descendant.

## For consideration
- Alert dialog themes may no longer need the `android` namespace, meaning themes can now be specified as `alertDialogTheme` rather than `android:alertDialogTheme`.

## Changelog:

[Android] [Changed] - Migrated `AlertFragment` dialog builder to use `androidx.appcompat`

Reviewed By: zeyap

Differential Revision: D57113950

Contributor

facebook-github-bot commented Jun 11, 2024

This pull request was exported from Phabricator. Differential Revision: D57113950

Abbondanzo force-pushed the export-D57113950 branch from 748404f to 70067f3 Compare

June 11, 2024 21:52

facebook-github-bot closed this in

297ded9

Contributor

facebook-github-bot commented Jun 12, 2024

This pull request has been merged in 297ded9.

facebook-github-bot added the Merged label

Abbondanzo deleted the export-D57113950 branch

June 12, 2024 18:33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed fb-exported Merged p: Facebook Partner