Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement getJavaScriptContextHolder for BridgelessCatalystInstance #44054

Closed

Conversation

arushikesarwani94
Copy link
Contributor

Summary:
Implement getJavaScriptContextHolder() for BridgelessCatalystInstance

Changelog:
[Android][Breaking] Implement getJavaScriptContextHolder() for Bridgeless Catalyst Instance

Differential Revision: D56046452

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 12, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56046452

Summary:
Implement `getJavaScriptContextHolder()` for BridgelessCatalystInstance

Changelog:
[Android][Breaking] Implement `getJavaScriptContextHolder()` for Bridgeless Catalyst Instance

Differential Revision: D56046452
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56046452

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 19,368,796 +10
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 22,743,715 +1
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 78d523d
Branch: main

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Apr 12, 2024
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in b72f5e9.

Copy link

This pull request was successfully merged by @arushikesarwani94 in b72f5e9.

When will my fix make it into a release? | How to file a pick request?

huntie pushed a commit that referenced this pull request Apr 15, 2024
…44054)

Summary:
Pull Request resolved: #44054

Implement `getJavaScriptContextHolder()` for BridgelessCatalystInstance

Changelog:
[Android][Breaking] Implement `getJavaScriptContextHolder()` for Bridgeless Catalyst Instance

Reviewed By: christophpurrer

Differential Revision: D56046452

fbshipit-source-id: b7fed1da3064608d8ef5fa84f4e53a4f7a84cba7
This was referenced Jun 28, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants