Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RN][Hermes] Fore Hermes versions for slices through env var #45840

Merged
merged 1 commit into from
Aug 4, 2024

Conversation

cipolleschi
Copy link
Contributor

@cipolleschi cipolleschi commented Jul 31, 2024

Summary:

We were building Hermes slices without passing the right version, as the mechanism that reads from the podspec got broken somehow.

This fix forces the versions for 0.74.

Changelog:

[General][Fixed] - Pass the right Apple system fvarsions to Hermes

Test Plan:

Wait for CircleCI to be green
Download the artifact
Verify that versions are set up correctly.

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Jul 31, 2024
@cipolleschi cipolleschi changed the base branch from main to 0.74-stable July 31, 2024 11:00
@cipolleschi cipolleschi marked this pull request as ready for review July 31, 2024 11:00
@analysis-bot
Copy link

analysis-bot commented Jul 31, 2024

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 17,857,517 -3,497,339
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 21,211,596 -3,338,395
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: fcd526d
Branch: main

@ajays97
Copy link

ajays97 commented Aug 4, 2024

Can someone please merge this? Thanks in advance

@Titozzz Titozzz merged commit 10e9669 into 0.74-stable Aug 4, 2024
55 checks passed
@ajays97
Copy link

ajays97 commented Aug 5, 2024

Which release includes this fix? Can someone please point me to it if published? Thanks

@macartigan
Copy link

Which release includes this fix? Can someone please point me to it if published? Thanks

Hello, look like in 0.74.5 → https://github.com/facebook/react-native/releases/tag/v0.74.5

@ajays97
Copy link

ajays97 commented Aug 6, 2024

Which release includes this fix? Can someone please point me to it if published? Thanks

Hello, look like in 0.74.5 → https://github.com/facebook/react-native/releases/tag/v0.74.5

Great, thanks a bunch 🤝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner Pick Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants