Remove REACT_NATIVE_SKIP_PREFAB as unused #41833
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51890227 |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Dec 7, 2023
Summary: I'm removing those environment variables as they're legacy and not used anymore: - REACT_NATIVE_SKIP_PREFAB - REACT_NATIVE_HERMES_SKIP_PREFAB Changelog: [Internal] [Changed] - Remove REACT_NATIVE_SKIP_PREFAB as unused Reviewed By: dmytrorykun Differential Revision: D51890227
cortinico
force-pushed
the
export-D51890227
branch
from
8c8ba48 to
3961d9c
Compare
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Dec 7, 2023
Summary: I'm removing those environment variables as they're legacy and not used anymore: - REACT_NATIVE_SKIP_PREFAB - REACT_NATIVE_HERMES_SKIP_PREFAB Changelog: [Internal] [Changed] - Remove REACT_NATIVE_SKIP_PREFAB as unused Reviewed By: dmytrorykun Differential Revision: D51890227
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Dec 7, 2023
Summary: I'm removing those environment variables as they're legacy and not used anymore: - REACT_NATIVE_SKIP_PREFAB - REACT_NATIVE_HERMES_SKIP_PREFAB Changelog: [Internal] [Changed] - Remove REACT_NATIVE_SKIP_PREFAB as unused Reviewed By: dmytrorykun Differential Revision: D51890227
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51890227 |
cortinico
force-pushed
the
export-D51890227
branch
from
3961d9c to
801ff1e
Compare
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Dec 8, 2023
Summary: I'm removing those environment variables as they're legacy and not used anymore: - REACT_NATIVE_SKIP_PREFAB - REACT_NATIVE_HERMES_SKIP_PREFAB Changelog: [Internal] [Changed] - Remove REACT_NATIVE_SKIP_PREFAB as unused Reviewed By: dmytrorykun Differential Revision: D51890227
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51890227 |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Dec 8, 2023
Summary: I'm removing those environment variables as they're legacy and not used anymore: - REACT_NATIVE_SKIP_PREFAB - REACT_NATIVE_HERMES_SKIP_PREFAB Changelog: [Internal] [Changed] - Remove REACT_NATIVE_SKIP_PREFAB as unused Reviewed By: dmytrorykun Differential Revision: D51890227
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Dec 8, 2023
Summary: I'm removing those environment variables as they're legacy and not used anymore: - REACT_NATIVE_SKIP_PREFAB - REACT_NATIVE_HERMES_SKIP_PREFAB Changelog: [Internal] [Changed] - Remove REACT_NATIVE_SKIP_PREFAB as unused Reviewed By: dmytrorykun Differential Revision: D51890227
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Dec 8, 2023
Summary: I'm removing those environment variables as they're legacy and not used anymore: - REACT_NATIVE_SKIP_PREFAB - REACT_NATIVE_HERMES_SKIP_PREFAB Changelog: [Internal] [Changed] - Remove REACT_NATIVE_SKIP_PREFAB as unused Reviewed By: dmytrorykun Differential Revision: D51890227
cortinico
force-pushed
the
export-D51890227
branch
from
801ff1e to
ae2a8f9
Compare
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Dec 8, 2023
Summary: I'm removing those environment variables as they're legacy and not used anymore: - REACT_NATIVE_SKIP_PREFAB - REACT_NATIVE_HERMES_SKIP_PREFAB Changelog: [Internal] [Changed] - Remove REACT_NATIVE_SKIP_PREFAB as unused Reviewed By: dmytrorykun Differential Revision: D51890227
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Dec 8, 2023
Summary: I'm removing those environment variables as they're legacy and not used anymore: - REACT_NATIVE_SKIP_PREFAB - REACT_NATIVE_HERMES_SKIP_PREFAB Changelog: [Internal] [Changed] - Remove REACT_NATIVE_SKIP_PREFAB as unused Reviewed By: dmytrorykun Differential Revision: D51890227
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Dec 8, 2023
Summary: I'm removing those environment variables as they're legacy and not used anymore: - REACT_NATIVE_SKIP_PREFAB - REACT_NATIVE_HERMES_SKIP_PREFAB Changelog: [Internal] [Changed] - Remove REACT_NATIVE_SKIP_PREFAB as unused Reviewed By: dmytrorykun Differential Revision: D51890227
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51890227 |
Base commit: 3ed4bf9 |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Dec 11, 2023
Summary: I'm removing those environment variables as they're legacy and not used anymore: - REACT_NATIVE_SKIP_PREFAB - REACT_NATIVE_HERMES_SKIP_PREFAB Changelog: [Internal] [Changed] - Remove REACT_NATIVE_SKIP_PREFAB as unused Reviewed By: dmytrorykun Differential Revision: D51890227
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Dec 11, 2023
Summary: I'm removing those environment variables as they're legacy and not used anymore: - REACT_NATIVE_SKIP_PREFAB - REACT_NATIVE_HERMES_SKIP_PREFAB Changelog: [Internal] [Changed] - Remove REACT_NATIVE_SKIP_PREFAB as unused Reviewed By: dmytrorykun Differential Revision: D51890227
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Dec 11, 2023
Summary: I'm removing those environment variables as they're legacy and not used anymore: - REACT_NATIVE_SKIP_PREFAB - REACT_NATIVE_HERMES_SKIP_PREFAB Changelog: [Internal] [Changed] - Remove REACT_NATIVE_SKIP_PREFAB as unused Reviewed By: dmytrorykun Differential Revision: D51890227
cortinico
force-pushed
the
export-D51890227
branch
from
ae2a8f9 to
bd4d434
Compare
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Dec 12, 2023
Summary: I'm removing those environment variables as they're legacy and not used anymore: - REACT_NATIVE_SKIP_PREFAB - REACT_NATIVE_HERMES_SKIP_PREFAB Changelog: [Internal] [Changed] - Remove REACT_NATIVE_SKIP_PREFAB as unused Reviewed By: dmytrorykun Differential Revision: D51890227
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51890227 |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Dec 12, 2023
Summary: I'm removing those environment variables as they're legacy and not used anymore: - REACT_NATIVE_SKIP_PREFAB - REACT_NATIVE_HERMES_SKIP_PREFAB Changelog: [Internal] [Changed] - Remove REACT_NATIVE_SKIP_PREFAB as unused Reviewed By: dmytrorykun Differential Revision: D51890227
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Dec 12, 2023
Summary: I'm removing those environment variables as they're legacy and not used anymore: - REACT_NATIVE_SKIP_PREFAB - REACT_NATIVE_HERMES_SKIP_PREFAB Changelog: [Internal] [Changed] - Remove REACT_NATIVE_SKIP_PREFAB as unused Reviewed By: dmytrorykun Differential Revision: D51890227
cortinico
force-pushed
the
export-D51890227
branch
from
bd4d434 to
b491d81
Compare
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Dec 12, 2023
Summary: I'm removing those environment variables as they're legacy and not used anymore: - REACT_NATIVE_SKIP_PREFAB - REACT_NATIVE_HERMES_SKIP_PREFAB Changelog: [Internal] [Changed] - Remove REACT_NATIVE_SKIP_PREFAB as unused Reviewed By: dmytrorykun Differential Revision: D51890227
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Dec 12, 2023
Summary: I'm removing those environment variables as they're legacy and not used anymore: - REACT_NATIVE_SKIP_PREFAB - REACT_NATIVE_HERMES_SKIP_PREFAB Changelog: [Internal] [Changed] - Remove REACT_NATIVE_SKIP_PREFAB as unused Reviewed By: dmytrorykun Differential Revision: D51890227
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51890227 |
Summary: I'm updating other two `build.gradle` to `build.gradle.kts` files. The only functional change I made was to remove the function to check if major >= 1 and turn on New Architecture. This needs to be moved to RNGP as Kotlin doesn't have dynamic accessors to Object so we can't convert that function. Changelog: [Internal] [Changed] - Convert ReactAndroid and RN-Tester to Kotlin DSL Reviewed By: mdvacca Differential Revision: D51856356
Summary: I'm removing those environment variables as they're legacy and not used anymore: - REACT_NATIVE_SKIP_PREFAB - REACT_NATIVE_HERMES_SKIP_PREFAB Changelog: [Internal] [Changed] - Remove REACT_NATIVE_SKIP_PREFAB as unused Reviewed By: dmytrorykun Differential Revision: D51890227
cortinico
force-pushed
the
export-D51890227
branch
from
b491d81 to
465ab37
Compare
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Dec 12, 2023
Summary: I'm removing those environment variables as they're legacy and not used anymore: - REACT_NATIVE_SKIP_PREFAB - REACT_NATIVE_HERMES_SKIP_PREFAB Changelog: [Internal] [Changed] - Remove REACT_NATIVE_SKIP_PREFAB as unused Reviewed By: dmytrorykun Differential Revision: D51890227
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51890227 |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Dec 12, 2023
Summary: I'm removing those environment variables as they're legacy and not used anymore: - REACT_NATIVE_SKIP_PREFAB - REACT_NATIVE_HERMES_SKIP_PREFAB Changelog: [Internal] [Changed] - Remove REACT_NATIVE_SKIP_PREFAB as unused Reviewed By: dmytrorykun Differential Revision: D51890227
Contributor
|
This pull request has been merged in 646ff6e. |
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
Summary: Pull Request resolved: facebook#41833 I'm removing those environment variables as they're legacy and not used anymore: - REACT_NATIVE_SKIP_PREFAB - REACT_NATIVE_HERMES_SKIP_PREFAB Changelog: [Internal] [Changed] - Remove REACT_NATIVE_SKIP_PREFAB as unused Reviewed By: dmytrorykun Differential Revision: D51890227 fbshipit-source-id: 6579ff73d3030fe1acb587250cd99aff44a1de29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
I'm removing those environment variables as they're legacy and not used anymore:
Changelog:
[Internal] [Changed] - Remove REACT_NATIVE_SKIP_PREFAB as unused
Reviewed By: dmytrorykun
Differential Revision: D51890227