Convert ReactAndroid and RN-Tester to Kotlin DSL #41834
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51856356 |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Dec 7, 2023
Summary: I'm updating other two `build.gradle` to `build.gradle.kts` files. The only functional change I made was to remove the function to check if major >= 1 and turn on New Architecture. This needs to be moved to RNGP as Kotlin doesn't have dynamic accessors to Object so we can't convert that function. Changelog: [Internal] [Changed] - Convert ReactAndroid and RN-Tester to Kotlin DSL Differential Revision: D51856356
cortinico
force-pushed
the
export-D51856356
branch
from
9b8f1af to
f412142
Compare
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Dec 7, 2023
Summary: I'm updating other two `build.gradle` to `build.gradle.kts` files. The only functional change I made was to remove the function to check if major >= 1 and turn on New Architecture. This needs to be moved to RNGP as Kotlin doesn't have dynamic accessors to Object so we can't convert that function. Changelog: [Internal] [Changed] - Convert ReactAndroid and RN-Tester to Kotlin DSL Differential Revision: D51856356
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Dec 7, 2023
Summary: I'm updating other two `build.gradle` to `build.gradle.kts` files. The only functional change I made was to remove the function to check if major >= 1 and turn on New Architecture. This needs to be moved to RNGP as Kotlin doesn't have dynamic accessors to Object so we can't convert that function. Changelog: [Internal] [Changed] - Convert ReactAndroid and RN-Tester to Kotlin DSL Differential Revision: D51856356
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51856356 |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Dec 8, 2023
Summary: I'm updating other two `build.gradle` to `build.gradle.kts` files. The only functional change I made was to remove the function to check if major >= 1 and turn on New Architecture. This needs to be moved to RNGP as Kotlin doesn't have dynamic accessors to Object so we can't convert that function. Changelog: [Internal] [Changed] - Convert ReactAndroid and RN-Tester to Kotlin DSL Differential Revision: D51856356
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Dec 8, 2023
Summary: I'm updating other two `build.gradle` to `build.gradle.kts` files. The only functional change I made was to remove the function to check if major >= 1 and turn on New Architecture. This needs to be moved to RNGP as Kotlin doesn't have dynamic accessors to Object so we can't convert that function. Changelog: [Internal] [Changed] - Convert ReactAndroid and RN-Tester to Kotlin DSL Differential Revision: D51856356
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Dec 8, 2023
Summary: I'm updating other two `build.gradle` to `build.gradle.kts` files. The only functional change I made was to remove the function to check if major >= 1 and turn on New Architecture. This needs to be moved to RNGP as Kotlin doesn't have dynamic accessors to Object so we can't convert that function. Changelog: [Internal] [Changed] - Convert ReactAndroid and RN-Tester to Kotlin DSL Differential Revision: D51856356
cortinico
force-pushed
the
export-D51856356
branch
from
f412142 to
d63f870
Compare
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Dec 8, 2023
Summary: I'm updating other two `build.gradle` to `build.gradle.kts` files. The only functional change I made was to remove the function to check if major >= 1 and turn on New Architecture. This needs to be moved to RNGP as Kotlin doesn't have dynamic accessors to Object so we can't convert that function. Changelog: [Internal] [Changed] - Convert ReactAndroid and RN-Tester to Kotlin DSL Differential Revision: D51856356
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Dec 8, 2023
Summary: I'm updating other two `build.gradle` to `build.gradle.kts` files. The only functional change I made was to remove the function to check if major >= 1 and turn on New Architecture. This needs to be moved to RNGP as Kotlin doesn't have dynamic accessors to Object so we can't convert that function. Changelog: [Internal] [Changed] - Convert ReactAndroid and RN-Tester to Kotlin DSL Differential Revision: D51856356
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51856356 |
cortinico
force-pushed
the
export-D51856356
branch
from
d63f870 to
1bb0c21
Compare
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Dec 8, 2023
Summary: I'm updating other two `build.gradle` to `build.gradle.kts` files. The only functional change I made was to remove the function to check if major >= 1 and turn on New Architecture. This needs to be moved to RNGP as Kotlin doesn't have dynamic accessors to Object so we can't convert that function. Changelog: [Internal] [Changed] - Convert ReactAndroid and RN-Tester to Kotlin DSL Differential Revision: D51856356
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51856356 |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Dec 8, 2023
Summary: I'm updating other two `build.gradle` to `build.gradle.kts` files. The only functional change I made was to remove the function to check if major >= 1 and turn on New Architecture. This needs to be moved to RNGP as Kotlin doesn't have dynamic accessors to Object so we can't convert that function. Changelog: [Internal] [Changed] - Convert ReactAndroid and RN-Tester to Kotlin DSL Differential Revision: D51856356
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Dec 8, 2023
Summary: I'm updating other two `build.gradle` to `build.gradle.kts` files. The only functional change I made was to remove the function to check if major >= 1 and turn on New Architecture. This needs to be moved to RNGP as Kotlin doesn't have dynamic accessors to Object so we can't convert that function. Changelog: [Internal] [Changed] - Convert ReactAndroid and RN-Tester to Kotlin DSL Differential Revision: D51856356
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Dec 8, 2023
Summary: I'm updating other two `build.gradle` to `build.gradle.kts` files. The only functional change I made was to remove the function to check if major >= 1 and turn on New Architecture. This needs to be moved to RNGP as Kotlin doesn't have dynamic accessors to Object so we can't convert that function. Changelog: [Internal] [Changed] - Convert ReactAndroid and RN-Tester to Kotlin DSL Differential Revision: D51856356
Base commit: 3ed4bf9 |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Dec 11, 2023
Summary: I'm updating other two `build.gradle` to `build.gradle.kts` files. The only functional change I made was to remove the function to check if major >= 1 and turn on New Architecture. This needs to be moved to RNGP as Kotlin doesn't have dynamic accessors to Object so we can't convert that function. Changelog: [Internal] [Changed] - Convert ReactAndroid and RN-Tester to Kotlin DSL Differential Revision: D51856356
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Dec 11, 2023
Summary: I'm updating other two `build.gradle` to `build.gradle.kts` files. The only functional change I made was to remove the function to check if major >= 1 and turn on New Architecture. This needs to be moved to RNGP as Kotlin doesn't have dynamic accessors to Object so we can't convert that function. Changelog: [Internal] [Changed] - Convert ReactAndroid and RN-Tester to Kotlin DSL Differential Revision: D51856356
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Dec 11, 2023
Summary: I'm updating other two `build.gradle` to `build.gradle.kts` files. The only functional change I made was to remove the function to check if major >= 1 and turn on New Architecture. This needs to be moved to RNGP as Kotlin doesn't have dynamic accessors to Object so we can't convert that function. Changelog: [Internal] [Changed] - Convert ReactAndroid and RN-Tester to Kotlin DSL Differential Revision: D51856356
cortinico
force-pushed
the
export-D51856356
branch
from
1bb0c21 to
fa17c79
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51856356 |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Dec 12, 2023
Summary: I'm updating other two `build.gradle` to `build.gradle.kts` files. The only functional change I made was to remove the function to check if major >= 1 and turn on New Architecture. This needs to be moved to RNGP as Kotlin doesn't have dynamic accessors to Object so we can't convert that function. Changelog: [Internal] [Changed] - Convert ReactAndroid and RN-Tester to Kotlin DSL Reviewed By: mdvacca Differential Revision: D51856356
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Dec 12, 2023
Summary: I'm updating other two `build.gradle` to `build.gradle.kts` files. The only functional change I made was to remove the function to check if major >= 1 and turn on New Architecture. This needs to be moved to RNGP as Kotlin doesn't have dynamic accessors to Object so we can't convert that function. Changelog: [Internal] [Changed] - Convert ReactAndroid and RN-Tester to Kotlin DSL Reviewed By: mdvacca Differential Revision: D51856356
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Dec 12, 2023
Summary: I'm updating other two `build.gradle` to `build.gradle.kts` files. The only functional change I made was to remove the function to check if major >= 1 and turn on New Architecture. This needs to be moved to RNGP as Kotlin doesn't have dynamic accessors to Object so we can't convert that function. Changelog: [Internal] [Changed] - Convert ReactAndroid and RN-Tester to Kotlin DSL Reviewed By: mdvacca Differential Revision: D51856356
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Dec 12, 2023
Summary: I'm updating other two `build.gradle` to `build.gradle.kts` files. The only functional change I made was to remove the function to check if major >= 1 and turn on New Architecture. This needs to be moved to RNGP as Kotlin doesn't have dynamic accessors to Object so we can't convert that function. Changelog: [Internal] [Changed] - Convert ReactAndroid and RN-Tester to Kotlin DSL Reviewed By: mdvacca Differential Revision: D51856356
cortinico
force-pushed
the
export-D51856356
branch
from
fa17c79 to
0c4e19c
Compare
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Dec 12, 2023
Summary: I'm updating other two `build.gradle` to `build.gradle.kts` files. The only functional change I made was to remove the function to check if major >= 1 and turn on New Architecture. This needs to be moved to RNGP as Kotlin doesn't have dynamic accessors to Object so we can't convert that function. Changelog: [Internal] [Changed] - Convert ReactAndroid and RN-Tester to Kotlin DSL Reviewed By: mdvacca Differential Revision: D51856356
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51856356 |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Dec 12, 2023
Summary: I'm updating other two `build.gradle` to `build.gradle.kts` files. The only functional change I made was to remove the function to check if major >= 1 and turn on New Architecture. This needs to be moved to RNGP as Kotlin doesn't have dynamic accessors to Object so we can't convert that function. Changelog: [Internal] [Changed] - Convert ReactAndroid and RN-Tester to Kotlin DSL Reviewed By: mdvacca Differential Revision: D51856356
Summary: I'm updating other two `build.gradle` to `build.gradle.kts` files. The only functional change I made was to remove the function to check if major >= 1 and turn on New Architecture. This needs to be moved to RNGP as Kotlin doesn't have dynamic accessors to Object so we can't convert that function. Changelog: [Internal] [Changed] - Convert ReactAndroid and RN-Tester to Kotlin DSL Reviewed By: mdvacca Differential Revision: D51856356
cortinico
force-pushed
the
export-D51856356
branch
from
0c4e19c to
c7b4e64
Compare
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Dec 12, 2023
Summary: I'm updating other two `build.gradle` to `build.gradle.kts` files. The only functional change I made was to remove the function to check if major >= 1 and turn on New Architecture. This needs to be moved to RNGP as Kotlin doesn't have dynamic accessors to Object so we can't convert that function. Changelog: [Internal] [Changed] - Convert ReactAndroid and RN-Tester to Kotlin DSL Reviewed By: mdvacca Differential Revision: D51856356
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Dec 12, 2023
Summary: I'm updating other two `build.gradle` to `build.gradle.kts` files. The only functional change I made was to remove the function to check if major >= 1 and turn on New Architecture. This needs to be moved to RNGP as Kotlin doesn't have dynamic accessors to Object so we can't convert that function. Changelog: [Internal] [Changed] - Convert ReactAndroid and RN-Tester to Kotlin DSL Reviewed By: mdvacca Differential Revision: D51856356
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51856356 |
|
This pull request was successfully merged by @cortinico in a115f97. When will my fix make it into a release? | Upcoming Releases |
Contributor
|
This pull request has been merged in a115f97. |
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
Summary: Pull Request resolved: facebook#41834 I'm updating other two `build.gradle` to `build.gradle.kts` files. The only functional change I made was to remove the function to check if major >= 1 and turn on New Architecture. This needs to be moved to RNGP as Kotlin doesn't have dynamic accessors to Object so we can't convert that function. Changelog: [Internal] [Changed] - Convert ReactAndroid and RN-Tester to Kotlin DSL Reviewed By: mdvacca Differential Revision: D51856356 fbshipit-source-id: ef75579cd3ec121ef6ac9a357c1e10bcf9995432
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
I'm updating other two
build.gradletobuild.gradle.ktsfiles.The only functional change I made was to remove the function to check if major >= 1 and turn on New Architecture. This needs to be moved to RNGP as Kotlin doesn't have dynamic accessors to Object so we can't convert that function.
Changelog:
[Internal] [Changed] - Convert ReactAndroid and RN-Tester to Kotlin DSL
Differential Revision: D51856356