Skip to content

Use new getCanonicalName and getMessage methods exposed by fbjni #37879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Use new getCanonicalName and getMessage methods exposed by fbjni #37879

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8ae1386
Update to new version of fbjni 0.3.1
krystofwoldrich Jun 12, 2023
8a199a1
Update gradle.properties
krystofwoldrich Jun 22, 2023
0b56ba7
Update build.gradle
krystofwoldrich Jun 22, 2023
55bef57
Update build.gradle remove mavenlocal
krystofwoldrich Jun 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-native/ReactAndroid/gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ ANDROIDX_AUTOFILL_VERSION=1.1.0
ANDROIDX_TEST_VERSION=1.1.0
ANDROIDX_TRACING_VERSION=1.1.0
ASSERTJ_VERSION=3.21.0
FBJNI_VERSION=0.3.0
FBJNI_VERSION=0.3.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work as of now as this version hasn't been published yet

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I've just opened this PR, to keep track that this will change with the next version. I'll adjust it to the actually release when it's out.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FBJNI_VERSION=0.4.0 should be out and ready to use in the next hours @krystofwoldrich

FRESCO_VERSION=2.5.0
INFER_ANNOTATIONS_VERSION=0.18.0
JAVAX_INJECT_VERSION=1
Expand Down
3 changes: 2 additions & 1 deletion packages/react-native/ReactAndroid/hermes-engine/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,7 @@ repositories {
// those repositories as there is no app module there.
mavenCentral()
google()
mavenLocal()
}

android {
Expand Down Expand Up @@ -220,7 +221,7 @@ android {
}

dependencies {
implementation("com.facebook.fbjni:fbjni:0.3.0")
implementation("com.facebook.fbjni:fbjni:0.3.1")
implementation("com.facebook.soloader:soloader:0.10.4")
implementation("com.facebook.yoga:proguard-annotations:1.19.0")
implementation("androidx.annotation:annotation:1.3.0")
Expand Down
12 changes: 3 additions & 9 deletions ...tive/ReactCommon/react/nativemodule/core/platform/android/ReactCommon/JavaTurboModule.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,15 +430,9 @@ jsi::JSError convertThrowableToJSError(
}

jsi::Object cause(runtime);
auto getName = throwable->getClass()
->getClass()
->getMethod<jni::local_ref<jni::JString>()>("getName");
auto getMessage =
throwable->getClass()->getMethod<jni::local_ref<jni::JString>()>(
"getMessage");
auto message = getMessage(throwable)->toStdString();
cause.setProperty(
runtime, "name", getName(throwable->getClass())->toStdString());
auto name = throwable->getClass()->getCanonicalName()->toStdString();
auto message = throwable->getMessage()->toStdString();
cause.setProperty(runtime, "name", name);
cause.setProperty(runtime, "message", message);
cause.setProperty(runtime, "stackElements", std::move(stackElements));

Expand Down