Use new getCanonicalName and getMessage methods exposed by fbjni #37879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
fbjni 0.3.1 isn't shipped yet, right? I have a pending cleanup blocked on that too (I expect it to be 0.4.0 at this point). |
cortinico
reviewed
Jun 14, 2023
| ANDROIDX_TRACING_VERSION=1.1.0 | ||
| ASSERTJ_VERSION=3.21.0 | ||
| FBJNI_VERSION=0.3.0 | ||
| FBJNI_VERSION=0.3.1 |
There was a problem hiding this comment.
This won't work as of now as this version hasn't been published yet
There was a problem hiding this comment.
Yes, I've just opened this PR, to keep track that this will change with the next version. I'll adjust it to the actually release when it's out.
There was a problem hiding this comment.
FBJNI_VERSION=0.4.0 should be out and ready to use in the next hours @krystofwoldrich
Base commit: ede86a3 |
|
@javache has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cortinico
approved these changes
Jun 23, 2023
|
This pull request was successfully merged by @krystofwoldrich in 6c729ac. When will my fix make it into a release? | Upcoming Releases |
yayvery
pushed a commit
to discord/react-native
that referenced
this pull request
Jan 14, 2024
…bump to 0.5.1 (facebook#37879) Summary: When a new version of `fbjni` is released, we can simplify `getName` and `getMessage` calls on throwables. <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [ANDROID] [CHANGED] - Use new `getCanonicalName` and `getMessage` methods exposed by `fbjni` Pull Request resolved: facebook#37879 Test Plan: facebookincubator/fbjni#78 Reviewed By: cortinico Differential Revision: D46966561 Pulled By: javache fbshipit-source-id: f30720a30146cf8fe5125336435a1512063c253d
yayvery
pushed a commit
to discord/react-native
that referenced
this pull request
Jan 14, 2024
…bump to 0.5.1 (facebook#37879) Summary: When a new version of `fbjni` is released, we can simplify `getName` and `getMessage` calls on throwables. <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [ANDROID] [CHANGED] - Use new `getCanonicalName` and `getMessage` methods exposed by `fbjni` Pull Request resolved: facebook#37879 Test Plan: facebookincubator/fbjni#78 Reviewed By: cortinico Differential Revision: D46966561 Pulled By: javache fbshipit-source-id: f30720a30146cf8fe5125336435a1512063c253d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When a new version of
fbjniis released, we can simplifygetNameandgetMessagecalls on throwables.Changelog:
[ANDROID] [CHANGED] - Use new
getCanonicalNameandgetMessagemethods exposed byfbjniTest Plan:
facebookincubator/fbjni#78