Update usages of default ReactNativeConfig #33196
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Fixes compilation of Android template and renames the field according to Java guidelines. Changelog: [Android][Changed] - Rename field with default values for ReactConfig to DEFAULT_CONFIG Differential Revision: D34523356 fbshipit-source-id: 05bafae334083e8b0c0748e2c72a56d295b8db90
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D34523356 |
Base commit: e139ef0 |
Base commit: e139ef0 |
|
This pull request was successfully merged by @ShikaSD in 964e816. When will my fix make it into a release? | Upcoming Releases |
Saadnajmi
pushed a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Jan 15, 2023
Summary: Pull Request resolved: facebook#33196 Fixes compilation of Android template and renames the field according to Java guidelines. Changelog: [Android][Changed] - Rename field with default values for ReactConfig to DEFAULT_CONFIG Reviewed By: cortinico Differential Revision: D34523356 fbshipit-source-id: 46ed703e7ca8ab5e05879dd93e8e4d2d816c2d03
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes compilation of Android template and renames the field according to Java guidelines.
Changelog: [Android][Changed] - Rename field with default values for ReactConfig to DEFAULT_CONFIG
Differential Revision: D34523356