Skip to content

Commit 964e816

Browse files
Andrei Shikovfacebook-github-bot
Andrei Shikov
authored andcommitted
Update usages of default ReactNativeConfig (#33196)
Summary: Pull Request resolved: #33196 Fixes compilation of Android template and renames the field according to Java guidelines. Changelog: [Android][Changed] - Rename field with default values for ReactConfig to DEFAULT_CONFIG Reviewed By: cortinico Differential Revision: D34523356 fbshipit-source-id: 46ed703e7ca8ab5e05879dd93e8e4d2d816c2d03
1 parent 75348ac commit 964e816

File tree

3 files changed

+4
-3
lines changed

3 files changed

+4
-3
lines changed

ReactAndroid/src/main/java/com/facebook/react/fabric/ReactNativeConfig.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
@DoNotStrip
2424
public interface ReactNativeConfig {
2525

26-
public final ReactNativeConfig DefaultValuesReactNativeConfig = new EmptyReactNativeConfig();
26+
ReactNativeConfig DEFAULT_CONFIG = new EmptyReactNativeConfig();
2727

2828
/**
2929
* Get a boolean param by string name. Default should be false.

packages/rn-tester/android/app/src/main/java/com/facebook/react/uiapp/RNTesterApplication.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ public JSIModuleProvider<UIManager> getJSIModuleProvider() {
171171
return new FabricJSIModuleProvider(
172172
reactApplicationContext,
173173
componentFactory,
174-
ReactNativeConfig.DefaultValuesReactNativeConfig,
174+
ReactNativeConfig.DEFAULT_CONFIG,
175175
viewManagerRegistry);
176176
}
177177
});

template/android/app/src/main/java/com/helloworld/newarchitecture/MainApplicationReactNativeHost.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
import com.facebook.react.fabric.ComponentFactory;
1818
import com.facebook.react.fabric.CoreComponentsRegistry;
1919
import com.facebook.react.fabric.FabricJSIModuleProvider;
20+
import com.facebook.react.fabric.ReactNativeConfig;
2021
import com.facebook.react.uimanager.ViewManagerRegistry;
2122
import com.helloworld.BuildConfig;
2223
import com.helloworld.newarchitecture.components.MainComponentsRegistry;
@@ -104,7 +105,7 @@ public JSIModuleProvider<UIManager> getJSIModuleProvider() {
104105
return new FabricJSIModuleProvider(
105106
reactApplicationContext,
106107
componentFactory,
107-
ReactNativeConfig.DefaultValuesReactNativeConfig,
108+
ReactNativeConfig.DEFAULT_CONFIG,
108109
viewManagerRegistry);
109110
}
110111
});

0 commit comments

Comments
 (0)