-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: set disabled accessibilityState when TouchableHighlight is disabled #31135
Conversation
Base commit: dbf5fa2 |
Base commit: dbf5fa2 |
This is great and those test cases are awesome! 😍 Thank you so much for working on this! @lunaleaps Do you think the component should also be disabled if accessibilityState.disabled=true, if the disabled prop is not set? Like in this PR: #31001 |
Yea! I think it'd be good to have this consistent across the components. @Naturalclar can you follow the logic in #31001 where |
@lunaleaps Sure thing! made the change in 4dc00ba |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kacieb has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Thank you @Naturalclar for this contribution! I would like to give you a shout-out on Twitter and include you in our end-of-month issues update for your contribution. Do you have a Twitter we can tag? Is your twitter @ the same as your Github? |
@amarlette thank you! |
Thank you so much for this pull request!!! I made a few small changes to the test cases before landing, and wanted to let you know in case you write any future tests! Thanks so much for including the tests by the way, that will make sure this functionality doesn't break in the future. I changed the
This is because Thanks again for helping improve React Native's accessibility! 🎉 |
#30950
Summary
automatically set
disabled
to accessibilityState when TouchableHighlight is disabledChangelog
[General] [Changed] - Set disabled accessibilityState when TouchableHighlight is disabled
Test Plan
Tested on physical android device that pressing disabled TouchableHighlight announces "dim" when talkback is on