Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TouchableHighlight Component doesn't disable click functionality when disabled #30950

Closed
amarlette opened this issue Feb 10, 2021 · 3 comments
Closed

TouchableHighlight Component doesn't disable click functionality when disabled #30950

amarlette opened this issue Feb 10, 2021 · 3 comments
Labels
Accessibility Component: TouchableHighlight Good first issue Interested in collaborating? Take a stab at fixing one of these issues. Platform: Android Android applications. Resolution: Locked This issue was locked by the bot.

Comments

@amarlette
Copy link

amarlette commented Feb 10, 2021 •
edited
Loading

Description

When using a screen reader the TouchableHighlight component doesn't disable click functionality.

This issue is covered in-depth by parent issue #30840, please check there for more details.

React Native version:

0.63
@amarlette amarlette mentioned this issue Feb 10, 2021
Closed
19 tasks
@amarlette amarlette added Good first issue Interested in collaborating? Take a stab at fixing one of these issues. and removed Needs: Triage 🔍 labels Mar 5, 2021
@Naturalclar
Copy link
Contributor

I'd like to work on this issue :)

@Naturalclar Naturalclar mentioned this issue Mar 11, 2021
Closed
@amarlette
Copy link
Author

Thank you @Naturalclar for contributing! We appreciate your help in making React Native more accessible for everyone!

@amarlette amarlette linked a pull request Mar 15, 2021 that will close this issue
feat: set disabled accessibilityState when TouchableHighlight is disabled #31135
Closed
@robrechtme robrechtme mentioned this issue Mar 22, 2021
Closed
facebook-github-bot pushed a commit that referenced this issue Mar 22, 2021
@Naturalclar @facebook-github-bot
feat: set disabled accessibilityState when TouchableHighlight is disa…
f69e096 
…bled (#31135)

Summary:
#30950

automatically set `disabled` to accessibilityState when TouchableHighlight is disabled

## Changelog

<!-- Help reviewers and the release process by writing your own changelog entry. For an example, see:
https://github.com/facebook/react-native/wiki/Changelog
-->

[General] [Changed] - Set disabled accessibilityState when TouchableHighlight is disabled

Pull Request resolved: #31135

Test Plan: Tested on physical android device that pressing disabled TouchableHighlight announces "dim" when talkback is on

Reviewed By: yungsters, nadiia

Differential Revision: D27157207

Pulled By: kacieb

fbshipit-source-id: b8e24aad699c43cf02401b3ba39726a06b751995
@amarlette
Copy link
Author

Closed by the PR #31135. Thank you @Naturalclar!

@martinivanalfonso martinivanalfonso mentioned this issue May 16, 2021
Closed
@facebook facebook locked as resolved and limited conversation to collaborators Mar 22, 2022
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Mar 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Accessibility Component: TouchableHighlight Good first issue Interested in collaborating? Take a stab at fixing one of these issues. Platform: Android Android applications. Resolution: Locked This issue was locked by the bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: set disabled accessibilityState when TouchableHighlight is disabled Naturalclar/react-native
3 participants
@Naturalclar @amarlette @react-native-bot