-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug that index.android.bundle is missing when building a release AAB #30824
Fix bug that index.android.bundle is missing when building a release AAB #30824
Conversation
Base commit: 505f9fc |
@thanakij is it works also with proguard enabled? Because i have the same issue only with the proguard enabled. |
Yes, I have proguard enabled in my setting for my release build. |
@thanakij Perfect! |
I'am not using Proguard, but APK was crashed. |
Hi @lorenzoangelini, any news on this? :) |
Hi, can you try my patch to see if it works for you by either manually editing |
ok, I'm trying to generate apk few times. with dependsOn(currentBundleTask). how can I use patch-package? I don't know about it. |
Test with with dependsOn(currentBundleTask). [Generate APK 5 Times] First APK after clean is weird. |
Because my patch builds on top of this pull, I just need your help to check if you have those changes as well. |
Looks like this PR has now been included in v66.0 onwards with this PR: #32026 |
Summary
The official solution in this pull only solves some part of the issue #29398.
Next, I would like to see my additional step I suggested here get merged so I create this pull request :).
Changelog
[Android] [Fixed] - Fix missing index.android.bundle when building release AAB with gradle plugin 4.1
Test Plan
Already confirmed by many people in the thread.