-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use correct gradle packageTask and asserts dir for android libraries #32026
Conversation
Base commit: 6daf5bb |
Base commit: 6daf5bb |
@ShikaSD has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
f7cfeab
to
7f8348d
Compare
@cortinico has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
1 similar comment
@cortinico has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Thank you for the fix @Legion2 The change looks good and should be merged soon 👍 |
@cortinico merged this pull request in 88f0676. |
Summary
Fixes #29577 and react-native-community/upgrade-support#93, when building an android library the package task has a different name, which was not handled correctly in the react.gradle file. The fix uses the existing
packageTask
variable which is correctly set for applications and libraries. This PR also copies the bundled js file into the correct assets directory, which is different from the assets directory of applications.Changelog
[Android] [Fixed] - Fixed Android library builds with react.gradle file
Test Plan
Tested with my android library build which includes the
react.gradle
file and the build succeeded.