Migrating RNTester to Packages Directory #29567
Conversation
facebook-github-bot
added
the
CLA Signed
|
You cannot call it "RNTester" if it is inside of the packages folder. It'll have to be either |
|
@cpojer , okay got it. Should I proceed with |
|
@cpojer , I've made the suggested changes. I can squash the commits if the migration part looks good. |
packages/rn-tester/android/app/src/main/gen/com/facebook/react/uiapp/BuildConfig.java
Outdated
Show resolved
Hide resolved
| @@ -18,7 +18,7 @@ const RNTesterNavigationReducer = require('./utils/RNTesterNavigationReducer'); | |||
| const React = require('react'); | |||
| const URIActionMap = require('./utils/URIActionMap'); | |||
|
|
|||
| const nativeImageSource = require('../../Libraries/Image/nativeImageSource'); | |||
| const nativeImageSource = require('../../../Libraries/Image/nativeImageSource'); | |||
There was a problem hiding this comment.
This is a good example of the next step we'll take later to decouple RNTester from React Native. We should be able to set it up so that react-native resolves to '../../../, so that all of JavaScript references react-native, even if the native dependencies are still relative. Then we would work to treat the native deps the same way.
| @@ -2,310 +2,312 @@ | |||
| # yarn lockfile v1 | |||
There was a problem hiding this comment.
Doesn't the yarn.lock file change automatically? 🤔
There was a problem hiding this comment.
Not if the dependencies don't change.
|
Going to import this just to see what's failing internally |
|
Importing isn't working for me, could you try @cpojer? |
There was a problem hiding this comment.
@bigfootjon has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
@bigfootjon has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
@rickhanlonii has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was successfully merged by @stealthanthrax in 63992c0. When will my fix make it into a release? | Upcoming Releases |
Summary: This PR fixes a small leftover after the RNTester migration to the monorepo package - an invalid link in the `PanResponder` comment. Refs: * #29567 * facebook/react-native-website#2177 (the similar correction was a part of merged PR in the RN docs) ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://github.com/facebook/react-native/wiki/Changelog --> [Internal][Fixed] PanResponder: correct example link in comment Pull Request resolved: #30051 Test Plan: N/A Reviewed By: fkgozali Differential Revision: D24025065 Pulled By: hramos fbshipit-source-id: 190486e458fb8e83a35fa2d3c62f4483f3a4334d
Summary: ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://github.com/facebook/react-native/wiki/Changelog --> This PR aims to migrate the RNTester App to `packages` directory. But is currently, open to inspect the CI issues and resolve the merge conflicts. Currently done - Working on iOS - Working on Android - Detox Tests working on iOS Need to work on - Errors generated by the CI builds [General] [Changed] - Migrated the RNTester App to the packages directory. Pull Request resolved: facebook#29567 Test Plan: It runs on both ios and android for now and the detox iOS builds are working. Reviewed By: cpojer Differential Revision: D23034761 Pulled By: rickhanlonii fbshipit-source-id: e04bb06e1c7ef15d340206090d1575a871b9e6f5
Summary
Changelog
This PR aims to migrate the RNTester App to
packagesdirectory. But is currently, open to inspect the CI issues and resolve the merge conflicts.Currently done
Need to work on
[General] [Changed] - Migrated the RNTester App to the packages directory.
Test Plan
It runs on both ios and android for now and the detox iOS builds are working.