-
Notifications
You must be signed in to change notification settings - Fork 24.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detox setup #29296
Detox setup #29296
Conversation
Hi @AnshG714! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
@AnshG714 can you post a screenshot of the error you're seeing? |
@rickhanlonii The error is an Xcode build error: |
@AnshG714 Can you share the version of Xcode/Node/etc that you're using? You can run |
It looks like |
Hey @rickhanlonii!
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
@alloy sorry for the ping, are you familiar with |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
@rickhanlonii Don’t know offhand, but I’ll take a look-see 👍 |
Wow thanks @alloy, that fixed it 💛 |
Hi All, I understand this would not be the right stage for my question but I think the techies involved here can answer and possible solutions. Does DETOX work for a web app developed using react.js for UI testing automation? Looking forward for your valuable inputs. |
Hey @nitint007, not sure, I would ask in https://github.com/wix/Detox |
Going to close this in favor of #29567 (review) |
Summary
This PR isn't really meant to be merged in right now. This is more of a call for help, as suggested by @rickhanlonii. I primarily need help with the iOS setup. This is a branch that's being worked on from the MLH react-native repository.
Background
We have migrated the RNTester app to the packages folder (and deleted the old RNTester app). This was meant to separate RNTester from the react-native repository.
How to set up the project to replicate error
After cloning the repo, run
yarn link
in the rootreact-native
repository. Then, runyarn link react-native
inreact-native/packages/RNTester
. Runyarn install && cd ios && pod install.
OpenRNTester.xcworkspace
in theios
directory. You should see build errors (the error I get when I open it up is related to theXCTest
framework not being recognisable.