[iOS] fixes Xcode path issues containing whitespace when building Release #24810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
reimertz
changed the title
analysis-bot
suggested changes
May 10, 2019
scripts/react-native-xcode.sh
Outdated
| @@ -57,7 +57,7 @@ REACT_NATIVE_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)" | |||
| # in node_modules. | |||
| PROJECT_ROOT=${PROJECT_ROOT:-"$REACT_NATIVE_DIR/../.."} | |||
|
|
|||
| cd $PROJECT_ROOT | |||
| cd "$PROJECT_ROOT" | |||
There was a problem hiding this comment.
SC2164: (warning) Use cd ... || exit in case cd fails.
facebook-github-bot
approved these changes
May 13, 2019
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was successfully merged by Pierre Reimertz in f0770b6. When will my fix make it into a release? | Upcoming Releases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some users (me included) have projects located in quirky places, resulting whitespaces in the path.
An example, , I symlink into my iCloud drive which result in the following path
This commit quotes the variable to make sure it gets properly passed to the CLI.
For reference, similar issue that has been resolved: https://github.com/react-native/react-native/commit/7d4e94edccfc2f642fcbd1d6aa00756f02e3a525
Test Plan
I ran current tests without issues.
Any suggestions how to write a test that catch these issues in the future? I couldn't find any tests related to xcode builds.
Changelog
[iOS] [Fixed] - Fixes whitespace issues when building Release from Xcode