Skip to content

Commit f0770b6

Browse files
Pierre Reimertzfacebook-github-bot
Pierre Reimertz
authored andcommitted
fixes Xcode path issues containing whitespace when building Release (#24810)
Summary: Some users (me included) have projects located in quirky places, resulting whitespaces in the path. An example, , I symlink into my iCloud drive which result in the following path ``` /Users/r/Library/Mobile Documents/com~apple~CloudDocs/_/work/{a_company}/repos.nosync/app ``` This commit quotes the variable to make sure it gets properly passed to the CLI. For reference, similar issue that has been resolved: https://github.com/react-native/react-native/commit/7d4e94edccfc2f642fcbd1d6aa00756f02e3a525 Pull Request resolved: #24810 Differential Revision: D15316898 Pulled By: cpojer fbshipit-source-id: 4ed2c8391d65d1680e836bfce8c51dfb5763caed
1 parent 01c70f2 commit f0770b6

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

scripts/react-native-xcode.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ REACT_NATIVE_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)"
5757
# in node_modules.
5858
PROJECT_ROOT=${PROJECT_ROOT:-"$REACT_NATIVE_DIR/../.."}
5959

60-
cd $PROJECT_ROOT
60+
cd "$PROJECT_ROOT" || exit
6161

6262
# Define NVM_DIR and source the nvm.sh setup script
6363
[ -z "$NVM_DIR" ] && export NVM_DIR="$HOME/.nvm"

0 commit comments

Comments
 (0)