[Lean Core] Remove SnapshotViewIOS from public interface #23497
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
react-native-bot
added
Component: SnapshotViewIOS
Platform: iOS
cpojer
approved these changes
Feb 18, 2019
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Feb 18, 2019
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
ericlewis
pushed a commit
to ericlewis/react-native
that referenced
this pull request
Feb 20, 2019
Summary: Part of Lean Core facebook#23313 Removes `SnapshotViewIOS` from the public RN interface. I think there's a wider discussion to be had here about whether `RCTTest` should be part of the public distribution or at least whether this should be split into a separate utils package. It's mainly used by the RNTester app. It seems to be little known about but there are [some references to it online](https://blog.callstack.io/testing-your-react-native-apps-abfe41903dfd). [iOS] [Removed] - `SnapshotViewIOS` is no longer publicly exported from RN Pull Request resolved: facebook#23497 Differential Revision: D14123280 Pulled By: cpojer fbshipit-source-id: badaf6cb5d2195268f0f8b429fc11d6525747708
hramos
removed
Import Started
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of Lean Core #23313
Removes
SnapshotViewIOSfrom the public RN interface.I think there's a wider discussion to be had here about whether
RCTTestshould be part of the public distribution or at least whether this should be split into a separate utils package. It's mainly used by the RNTester app. It seems to be little known about but there are some references to it online.Changelog
[iOS] [Removed] -
SnapshotViewIOSis no longer publicly exported from RNTest Plan
SnapshotViewIOScan no longer be imported from the public exports