Skip to content

Commit

Permalink
Remove SnapshotViewIOS from public interface (facebook#23497)
Browse files Browse the repository at this point in the history
Summary:
Part of Lean Core facebook#23313

Removes `SnapshotViewIOS` from the public RN interface.

I think there's a wider discussion to be had here about whether `RCTTest` should be part of the public distribution or at least whether this should be split into a separate utils package. It's mainly used by the RNTester app. It seems to be little known about but there are [some references to it online](https://blog.callstack.io/testing-your-react-native-apps-abfe41903dfd).

[iOS] [Removed] - `SnapshotViewIOS` is no longer publicly exported from RN
Pull Request resolved: facebook#23497

Differential Revision: D14123280

Pulled By: cpojer

fbshipit-source-id: badaf6cb5d2195268f0f8b429fc11d6525747708
  • Loading branch information
jdmunro authored and ericlewis committed Feb 20, 2019
1 parent d097951 commit 2ac9cc1
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 4 deletions.
3 changes: 0 additions & 3 deletions Libraries/react-native/react-native-implementation.js
Original file line number Diff line number Diff line change
Expand Up @@ -124,9 +124,6 @@ module.exports = {
);
return require('Slider');
},
get SnapshotViewIOS() {
return require('SnapshotViewIOS');
},
get Switch() {
return require('Switch');
},
Expand Down
2 changes: 1 addition & 1 deletion RNTester/js/RNTesterApp.ios.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,12 @@ const RNTesterExampleContainer = require('./RNTesterExampleContainer');
const RNTesterExampleList = require('./RNTesterExampleList');
const RNTesterList = require('./RNTesterList.ios');
const RNTesterNavigationReducer = require('./RNTesterNavigationReducer');
const SnapshotViewIOS = require('./SnapshotViewIOS.ios');
const URIActionMap = require('./URIActionMap');

const {
Button,
AppRegistry,
SnapshotViewIOS,
StyleSheet,
Text,
View,
Expand Down
File renamed without changes.
File renamed without changes.

0 comments on commit 2ac9cc1

Please sign in to comment.