Update fri 29 may #1446
Merged
Update fri 29 may #1446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: @public Allow to pass an optional completion block to the bridge JS calls. The block will be called from the JS thread, after the javascript has finished running and the returned calls have been processed/dispatched to the native modules. Test Plan: Added `testCallbackIsCalledOnTheRightTime` to `RKBatchedBridgeTests`
…l:args:]" Test plan: broke catalyst apps Summary: This reverts commit 9fba6a360dc5f8bf. fbobjc/Tools/revert Reverter: jprado @build-break commit 9fba6a360dc5f8bf014f3d3c584c545b16da5100 Author: Tadeu Zagallo <[email protected]> AuthorDate: Thu May 28 08:29:19 2015 -0700 Commit: Service User <[email protected]> CommitDate: Thu May 28 09:53:53 2015 -0700 [ReactNative] Add completionBlock to -[RCTBridge enqueueJSCall:args:] Summary: @public Allow to pass an optional completion block to the bridge JS calls. The block will be called from the JS thread, after the javascript has finished running and the returned calls have been processed/dispatched to the native modules. Test Plan: Added `testCallbackIsCalledOnTheRightTime` to `RKBatchedBridgeTests`
Summary: @public This fixes an issue with the containerBackgroundColor property of `<Text>` nodes, where containerBackgroundColor was being overridden by the backgroundColor. I also fixed up the example so that it demonstrates the feature more clearly. Test Plan: * Check UIExplorer text example * Run Catalyst snapshot tests and check MAdMan, Groups
Summary: Add the license field on package.json Closes facebook#1409 Github Author: Leonardo YongUk Kim <[email protected]> Test Plan: Imported from GitHub, without a `Test Plan:` line.
…er, and opening UIExplorer, MAdMan, Groups
facebook-github-bot
added
GH Review: review-needed
CLA Signed
… adapt TextViewManager to shadowview-less design.
tadeuzagallo
force-pushed
the
Update_Fri_29_May
branch
2 times, most recently
from
db63644 to
c6b7eb7
Compare
tadeuzagallo
force-pushed
the
Update_Fri_29_May
branch
from
c6b7eb7 to
1567e82
Compare
Contributor
|
EDIT: Striking comment because I put it on the wrong issue :/
|
Contributor
Author
|
I merged #1432 with the commits up to yesterday, these commits are today's, they don't have any commit in common. Be careful before closing things. |
Contributor
|
@tadeuzagallo sorry my mistake -- i posted my comment to the wrong tab in my browser, and it should have gone to this page. (Will note this on my earlier comment.) |
Contributor
Author
|
Oh, I see. Closed it, Thanks! |
tadeuzagallo
force-pushed
the
Update_Fri_29_May
branch
from
2978b10 to
b225e84
Compare
tadeuzagallo
force-pushed
the
Update_Fri_29_May
branch
3 times, most recently
from
8e92a9e to
d700e92
Compare
tadeuzagallo
force-pushed
the
Update_Fri_29_May
branch
from
d700e92 to
8976a05
Compare
ayushjainrksh
pushed a commit
to MLH-Fellowship/react-native
that referenced
this pull request
Jul 2, 2020
mganandraj
pushed a commit
to mganandraj/react-native
that referenced
this pull request
Dec 6, 2022
AB#6558463 Remove temporary patch to emit warning instead of error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.