Add the license field on package.json #1409
Closed
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
GH Review: review-needed
CLA Signed
Contributor
|
jest is unrelated to testing:https://www.npmjs.com/package/jest |
Contributor
Author
|
Oh. I had a mistake. I thought jest is needed. I have to remove jest on package.json. Thanks @ide |
Contributor
|
Sounds good, react has the same https://github.com/facebook/react/blob/master/package.json#L13 |
Contributor
|
@facebook-github-bot import |
Contributor
|
Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/831340873568138/int_phab to review. |
tadeuzagallo
pushed a commit
to tadeuzagallo/react-native
that referenced
this pull request
May 29, 2015
Summary: Add the license field on package.json Closes facebook#1409 Github Author: Leonardo YongUk Kim <[email protected]> Test Plan: Imported from GitHub, without a `Test Plan:` line.
Collaborator
|
This made it into today's sync, closing! |
ayushjainrksh
pushed a commit
to MLH-Fellowship/react-native
that referenced
this pull request
Jul 2, 2020
It made me confused when I tried config module-resolver, especially, in `tsconfig` and `module-resolver` alias part.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the license field on package.json