Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lexical][CI] Add more ||ism in e2e tests to decrease overall run time #6237

Merged
merged 2 commits into from
Jun 3, 2024
Merged

[Lexical][CI] Add more ||ism in e2e tests to decrease overall run time #6237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5595a6f
run tests in file with slow tests in || to fix the slow test warning …
Sahejkm Jun 3, 2024
cfe0025
Add more || workers for CI
Sahejkm Jun 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/lexical-playground/__tests__/e2e/Links.spec.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ test.beforeEach(({isPlainText}) => {
test.skip(isPlainText);
});

test.describe('Links', () => {
test.describe.parallel('Links', () => {
test.beforeEach(({isCollab, page}) => initialize({isCollab, page}));
test(`Can convert a text node into a link`, async ({page}) => {
await focusEditor(page);
Expand Down
2 changes: 1 addition & 1 deletion packages/lexical-playground/__tests__/e2e/List.spec.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ test.beforeEach(({isPlainText}) => {
test.skip(isPlainText);
});

test.describe('Nested List', () => {
test.describe.parallel('Nested List', () => {
test.beforeEach(({isCollab, page}) => initialize({isCollab, page}));

test(`Can create a list and partially copy some content out of it`, async ({
Expand Down
4 changes: 2 additions & 2 deletions packages/lexical-playground/__tests__/e2e/Markdown.spec.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ async function checkHTMLExpectationsIncludingUndoRedo(
await assertHTML(page, forwardHTML);
}

test.describe('Markdown', () => {
test.describe.parallel('Markdown', () => {
test.beforeEach(({isCollab, page}) => initialize({isCollab, page}));
const triggersAndExpectations = [
{
Expand Down Expand Up @@ -374,7 +374,7 @@ async function assertMarkdownImportExport(
await assertHTML(page, expectedHTML);
}

test.describe('Markdown', () => {
test.describe.parallel('Markdown', () => {
test.beforeEach(({isCollab, isPlainText, page}) => {
test.skip(isPlainText);
return initialize({isCollab, page});
Expand Down
2 changes: 1 addition & 1 deletion packages/lexical-playground/__tests__/e2e/Selection.spec.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ import {
YOUTUBE_SAMPLE_URL,
} from '../utils/index.mjs';

test.describe('Selection', () => {
test.describe.parallel('Selection', () => {
test.beforeEach(({isCollab, page}) => initialize({isCollab, page}));
test('does not focus the editor on load', async ({page}) => {
const editorHasFocus = async () =>
Expand Down
7 changes: 4 additions & 3 deletions packages/lexical-playground/__tests__/e2e/Tables.spec.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ async function fillTablePartiallyWithText(page) {
await page.keyboard.press('c');
}

test.describe('Tables', () => {
test.describe.parallel('Tables', () => {
test(`Can a table be inserted from the toolbar`, async ({
page,
isPlainText,
Expand Down Expand Up @@ -152,7 +152,8 @@ test.describe('Tables', () => {
);
});

test.describe(`Can exit tables with the horizontal arrow keys`, () => {
test.describe
.parallel(`Can exit tables with the horizontal arrow keys`, () => {
test(`Can exit the first cell of a non-nested table`, async ({
page,
isPlainText,
Expand Down Expand Up @@ -488,7 +489,7 @@ test.describe('Tables', () => {
});
});

test.describe(`Can navigate table with keyboard`, () => {
test.describe.parallel(`Can navigate table with keyboard`, () => {
test(`Can navigate cells horizontally`, async ({
page,
isPlainText,
Expand Down
2 changes: 1 addition & 1 deletion packages/lexical-playground/__tests__/e2e/TextFormatting.spec.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ import {
waitForSelector,
} from '../utils/index.mjs';

test.describe('TextFormatting', () => {
test.describe.parallel('TextFormatting', () => {
test.beforeEach(({isCollab, page}) => initialize({isCollab, page}));
test(`Can create bold text using the shortcut`, async ({
page,
Expand Down
1 change: 1 addition & 0 deletions playwright.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,5 +48,6 @@ const config = {
timeout: 120 * 1000,
}
: undefined,
workers: 4,
};
module.exports = config;
Loading