Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lexical][CI] Add more ||ism in e2e tests to decrease overall run time #6237

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

Sahejkm
Copy link
Contributor

@Sahejkm Sahejkm commented Jun 3, 2024

WHAT

  • Add ||ism in slow test files by changing test.describe to test.describe.parallel
  • Add ||ism in workers - in CI we were using just 1 worker while in local dev machines we use 4 workers, change to 4 workers in CI as well to make the tests run faster

https://playwright.dev/docs/test-parallel

WHY

  • Lower the running time for github workflows related to e2e tests and hence lower the spend

Test Plan

Before: https://github.com/facebook/lexical/actions/runs/9342978263/usage?pr=6198
~6h

After: https://github.com/facebook/lexical/actions/runs/9344275667/usage?pr=6237
~3h 45min

Copy link

vercel bot commented Jun 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2024 4:28am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2024 4:28am

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 3, 2024
@Sahejkm Sahejkm added the extended-tests Run extended e2e tests on a PR label Jun 3, 2024
Copy link

github-actions bot commented Jun 3, 2024

size-limit report 📦

Path Size
lexical - cjs 28.33 KB (0%)
lexical - esm 28.14 KB (0%)
@lexical/rich-text - cjs 36.72 KB (-0.11% 🔽)
@lexical/rich-text - esm 28.1 KB (0%)
@lexical/plain-text - cjs 35.37 KB (0%)
@lexical/plain-text - esm 25.33 KB (0%)
@lexical/react - cjs 38.52 KB (0%)
@lexical/react - esm 29.12 KB (0%)

@Sahejkm Sahejkm changed the title testing ||ism in e2e tests [testing][Lexical] Add more ||ism in e2e tests to decrease overall run time Jun 3, 2024
@Sahejkm Sahejkm changed the title [testing][Lexical] Add more ||ism in e2e tests to decrease overall run time [Lexical][CI] Add more ||ism in e2e tests to decrease overall run time Jun 3, 2024
@Sahejkm Sahejkm marked this pull request as ready for review June 3, 2024 04:49
@Sahejkm
Copy link
Contributor Author

Sahejkm commented Jun 3, 2024

cancelled pull_request_review workflow manually causing re-trigger of extended tests run, the label 'extended-tests' was already there, it shouldn't have rerun the tests, unless the label was manually removed. will investigate separately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. extended-tests Run extended e2e tests on a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants