-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lexical][CI] Add more ||ism in e2e tests to decrease overall run time #6237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and imporve test run time
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Jun 3, 2024
size-limit report 📦
|
Sahejkm
changed the title
testing ||ism in e2e tests
[testing][Lexical] Add more ||ism in e2e tests to decrease overall run time
Jun 3, 2024
Sahejkm
changed the title
[testing][Lexical] Add more ||ism in e2e tests to decrease overall run time
[Lexical][CI] Add more ||ism in e2e tests to decrease overall run time
Jun 3, 2024
Sahejkm
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz,
ivailop7 and
potatowagon
as code owners
June 3, 2024 04:49
potatowagon
approved these changes
Jun 3, 2024
cancelled pull_request_review workflow manually causing re-trigger of extended tests run, the label 'extended-tests' was already there, it shouldn't have rerun the tests, unless the label was manually removed. will investigate separately |
This was referenced Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
extended-tests
Run extended e2e tests on a PR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
https://playwright.dev/docs/test-parallel
WHY
Test Plan
Before: https://github.com/facebook/lexical/actions/runs/9342978263/usage?pr=6198
~6h
After: https://github.com/facebook/lexical/actions/runs/9344275667/usage?pr=6237
~3h 45min