Fix OverflowNode configuration #6027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zurfyx
requested review from
fantactuka,
acywatson,
Fetz and
ivailop7
as code owners
facebook-github-bot
added
the
CLA Signed
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
ivailop7
approved these changes
May 6, 2024
|
#6456 may also fix this incidentally because it adds a transform to prevent empty OverflowNode |
etrepum
approved these changes
Aug 11, 2024
This was referenced Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OverflowNode was badly configured, this was revealed by #6025. It is always inline and can't be empty. Surprisingly, the current configuration was passing all tests fine but the video below show some surprisingly bad behavior when we only fix isInline, we can't have dangling empty span.
Before:
Screen.Recording.2024-05-04.at.4.20.55.PM.mov
After:
Screen.Recording.2024-05-04.at.4.18.55.PM.mov