Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Regression in test suite after merging #6027 (Fix OverflowNode configuration) #6534

Closed
etrepum opened this issue Aug 21, 2024 · 0 comments · Fixed by #6535
Closed

Bug: Regression in test suite after merging #6027 (Fix OverflowNode configuration) #6534

etrepum opened this issue Aug 21, 2024 · 0 comments · Fixed by #6535

Comments

@etrepum
Copy link
Collaborator

etrepum commented Aug 21, 2024

Test failures since #6027. It must've been in a state where the extended test suite wasn't running, so there were no plain text e2e tests run and the PR was green when it was merged.

For example:

  4 failed
    [webkit] › packages/lexical-playground/__tests__/e2e/CharacterLimit.spec.mjs:120:3 › CharacterLimit › UTF-16 › can type new lines inside overflow 
    [webkit] › packages/lexical-playground/__tests__/e2e/CharacterLimit.spec.mjs:175:3 › CharacterLimit › UTF-16 › can delete text in front and overflow is recomputed 
    [webkit] › packages/lexical-playground/__tests__/e2e/CharacterLimit.spec.mjs:120:3 › CharacterLimit › UTF-8 › can type new lines inside overflow 
    [webkit] › packages/lexical-playground/__tests__/e2e/CharacterLimit.spec.mjs:175:3 › CharacterLimit › UTF-8 › can delete text in front and overflow is recomputed 

Lexical version: nightly

Steps To Reproduce

npm run test-e2e-plain-*

The current behavior

Tests fail

The expected behavior

Tests pass

Impact of fix

Unblock PRs

@etrepum etrepum changed the title Bug: Regression in test suite after merging #6027 Bug: Regression in test suite after merging #6027 (Fix OverflowNode configuration) Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant