Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[build] Chore: Upgrade rollup and vite to latest versions #6018

Merged
merged 16 commits into from
May 4, 2024
Merged

[build] Chore: Upgrade rollup and vite to latest versions #6018

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
6086471
fix type issue from #5977
etrepum May 2, 2024
f5afcb2
chore(build) upgrade rollup, vite, and related plugins to latest vers…
etrepum May 3, 2024
c5910f2
upgrade eslint
etrepum May 3, 2024
6a00ace
use createRequire
etrepum May 3, 2024
b7159dd
commonjs & excalidraw eval
etrepum May 3, 2024
f591d14
Use build artifacts not typescript sources for playground build
etrepum May 3, 2024
ca1684d
update docusaurus
etrepum May 3, 2024
8bf1ec7
avoid shadowing globals
etrepum May 3, 2024
43e1adb
explicit types for tsc
etrepum May 3, 2024
ef4e547
unify vite module resolution
etrepum May 3, 2024
87f93e9
use dev build of playground/lexical on vercel
etrepum May 3, 2024
94a6459
remove unused packages.js
etrepum May 3, 2024
c2d3246
module with side-effects was optimized away :see_no_evil:
etrepum May 3, 2024
ac22cf2
update actions and fix cache key inconsistency
etrepum May 3, 2024
3f0f885
hard-coded hashed asset paths :grimacing:
etrepum May 3, 2024
4e4f478
that tree shaking sure is aggressive
etrepum May 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ module.exports = {
'packages/*/__tests__/**/*.?(m)js',
'packages/*/src/**/*.jsx',
],
parser: 'babel-eslint',
parser: '@babel/eslint-parser',
parserOptions: {
allowImportExportEverywhere: true,
sourceType: 'module',
Expand Down Expand Up @@ -97,7 +97,7 @@ module.exports = {
},
],

parser: 'babel-eslint',
parser: '@babel/eslint-parser',

parserOptions: {
ecmaFeatures: {
Expand Down Expand Up @@ -137,9 +137,9 @@ module.exports = {
'eol-last': ERROR,
eqeqeq: [ERROR, 'allow-null'],
// Prettier forces semicolons in a few places
'flowtype/object-type-delimiter': OFF,
'ft-flow/object-type-delimiter': OFF,

'flowtype/sort-keys': ERROR,
'ft-flow/sort-keys': ERROR,

'header/header': [2, 'scripts/www/headerTemplate.js'],

Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/devtools-extension-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,22 +14,22 @@ jobs:
if: github.repository_owner == 'facebook'
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- name: Configure Node.js
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: 20.x
cache: 'npm'

- uses: actions/cache@v3
- uses: actions/cache@v4
id: devtools-cache
with:
path: |
node_modules
packages/lexical-devtools/.wxt
~/.cache/ms-playwright
key: ${{ runner.os }}-${{ runner.arch }}v${{ secrets.CACHE_VERSION }}-${{ hashFiles('package-lock.json') }}
key: ${{ runner.os }}-${{ runner.arch }}-v${{ secrets.CACHE_VERSION }}-${{ hashFiles('package-lock.json') }}

- name: Install dependencies
if: steps.devtools-cache.outputs.cache-hit != 'true'
Expand Down
88 changes: 44 additions & 44 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,19 +26,19 @@ jobs:
CI: true
GITHUB_TOKEN: ${{ secrets.DANGER_GITHUB_API_TOKEN }}
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
- run: npm i -g npm@8
- uses: actions/cache@v3
- uses: actions/cache@v4
id: cache
with:
path: |
node_modules
~/.cache/ms-playwright
key: ${{ runner.os }}-${{ runner.arch }}v${{ secrets.CACHE_VERSION }}-${{ hashFiles('package-lock.json') }}
key: ${{ runner.os }}-${{ runner.arch }}-v${{ secrets.CACHE_VERSION }}-${{ hashFiles('package-lock.json') }}
- name: Install dependencies
if: steps.cache.outputs.cache-hit != 'true'
run: npm ci
Expand All @@ -55,19 +55,19 @@ jobs:
env:
CI: true
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
- run: npm i -g npm@8
- uses: actions/cache@v3
- uses: actions/cache@v4
id: cache
with:
path: |
node_modules
~/.cache/ms-playwright
key: ${{ runner.os }}-${{ runner.arch }}v${{ secrets.CACHE_VERSION }}-${{ hashFiles('package-lock.json') }}
key: ${{ runner.os }}-${{ runner.arch }}-v${{ secrets.CACHE_VERSION }}-${{ hashFiles('package-lock.json') }}
- name: Install dependencies
if: steps.cache.outputs.cache-hit != 'true'
run: npm ci
Expand All @@ -82,19 +82,19 @@ jobs:
env:
CI: true
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
- run: npm i -g npm@8
- uses: actions/cache@v3
- uses: actions/cache@v4
id: cache
with:
path: |
node_modules
~/.cache/ms-playwright
key: ${{ runner.os }}-${{ runner.arch }}v${{ secrets.CACHE_VERSION }}-${{ hashFiles('package-lock.json') }}
key: ${{ runner.os }}-${{ runner.arch }}-v${{ secrets.CACHE_VERSION }}-${{ hashFiles('package-lock.json') }}
- name: Install dependencies
if: steps.cache.outputs.cache-hit != 'true'
run: npm ci
Expand All @@ -114,20 +114,20 @@ jobs:
E2E_EDITOR_MODE: ${{ matrix.editor-mode }}
E2E_EVENTS_MODE: ${{ matrix.events-mode }}
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
- run: npm i -g npm@8
- uses: actions/cache@v3
- uses: actions/cache@v4
id: cache
with:
path: |
node_modules
packages/playwright-core/node_modules
~/Library/Caches/ms-playwright
key: ${{ runner.os }}-${{ runner.arch }}v${{ secrets.CACHE_VERSION }}-${{ hashFiles('package-lock.json') }}
key: ${{ runner.os }}-${{ runner.arch }}-v${{ secrets.CACHE_VERSION }}-${{ hashFiles('package-lock.json') }}
- name: Install dependencies
if: steps.cache.outputs.cache-hit != 'true'
run: npm ci
Expand Down Expand Up @@ -156,24 +156,24 @@ jobs:
E2E_EDITOR_MODE: ${{ matrix.editor-mode }}
E2E_EVENTS_MODE: ${{ matrix.events-mode }}
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
- name: install required packages
run: |
sudo apt-get update
sudo apt-get install xvfb
- run: npm i -g npm@8
- uses: actions/cache@v3
- uses: actions/cache@v4
id: cache
with:
path: |
node_modules
packages/playwright-core/node_modules
~/.cache/ms-playwright
key: ${{ runner.os }}-${{ runner.arch }}v${{ secrets.CACHE_VERSION }}-${{ hashFiles('package-lock.json') }}
key: ${{ runner.os }}-${{ runner.arch }}-v${{ secrets.CACHE_VERSION }}-${{ hashFiles('package-lock.json') }}
- name: Install dependencies
if: steps.cache.outputs.cache-hit != 'true'
run: npm ci
Expand Down Expand Up @@ -202,19 +202,19 @@ jobs:
E2E_EDITOR_MODE: ${{ matrix.editor-mode }}
E2E_EVENTS_MODE: ${{ matrix.events-mode }}
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
- run: npm i -g npm@8
# - uses: actions/cache@v3
# - uses: actions/cache@v4
# id: cache
# with:
# path: |
# node_modules
# C:\Users\runneradmin\AppData\Local\ms-playwright
# key: ${{ runner.os }}-${{ runner.arch }}v${{ secrets.CACHE_VERSION }}-${{ hashFiles('package-lock.json') }}
# key: ${{ runner.os }}-${{ runner.arch }}-v${{ secrets.CACHE_VERSION }}-${{ hashFiles('package-lock.json') }}
# - name: Install dependencies
# if: steps.cache.outputs.cache-hit != 'true'
- run: npm ci
Expand All @@ -239,20 +239,20 @@ jobs:
env:
CI: true
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
- run: npm i -g npm@8
- uses: actions/cache@v3
- uses: actions/cache@v4
id: cache
with:
path: |
node_modules
packages/playwright-core/node_modules
~/Library/Caches/ms-playwright
key: ${{ runner.os }}-${{ runner.arch }}v${{ secrets.CACHE_VERSION }}-${{ hashFiles('package-lock.json') }}
key: ${{ runner.os }}-${{ runner.arch }}-v${{ secrets.CACHE_VERSION }}-${{ hashFiles('package-lock.json') }}
- name: Install dependencies
if: steps.cache.outputs.cache-hit != 'true'
run: npm ci
Expand All @@ -277,24 +277,24 @@ jobs:
env:
CI: true
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
- run: npm i -g npm@8
- name: install required packages
run: |
sudo apt-get update
sudo apt-get install xvfb
- uses: actions/cache@v3
- uses: actions/cache@v4
id: cache
with:
path: |
node_modules
packages/playwright-core/node_modules
~/.cache/ms-playwright
key: ${{ runner.os }}-${{ runner.arch }}v${{ secrets.CACHE_VERSION }}-${{ hashFiles('package-lock.json') }}
key: ${{ runner.os }}-${{ runner.arch }}-v${{ secrets.CACHE_VERSION }}-${{ hashFiles('package-lock.json') }}
- name: Install dependencies
if: steps.cache.outputs.cache-hit != 'true'
run: npm ci
Expand All @@ -319,19 +319,19 @@ jobs:
env:
CI: true
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
- run: npm i -g npm@8
- uses: actions/cache@v3
- uses: actions/cache@v4
id: cache
with:
path: |
node_modules
C:\Users\runneradmin\AppData\Local\ms-playwright
key: ${{ runner.os }}-${{ runner.arch }}v${{ secrets.CACHE_VERSION }}-${{ hashFiles('package-lock.json') }}
key: ${{ runner.os }}-${{ runner.arch }}-v${{ secrets.CACHE_VERSION }}-${{ hashFiles('package-lock.json') }}
- name: Install dependencies
# if: steps.cache.outputs.cache-hit != 'true'
run: npm ci
Expand Down Expand Up @@ -360,20 +360,20 @@ jobs:
E2E_EDITOR_MODE: ${{ matrix.editor-mode }}
E2E_EVENTS_MODE: ${{ matrix.events-mode }}
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
- run: npm i -g npm@8
- uses: actions/cache@v3
- uses: actions/cache@v4
id: cache
with:
path: |
node_modules
packages/playwright-core/node_modules
~/Library/Caches/ms-playwright
key: ${{ runner.os }}-${{ runner.arch }}v${{ secrets.CACHE_VERSION }}-${{ hashFiles('package-lock.json') }}
key: ${{ runner.os }}-${{ runner.arch }}-v${{ secrets.CACHE_VERSION }}-${{ hashFiles('package-lock.json') }}
- name: Install dependencies
if: steps.cache.outputs.cache-hit != 'true'
run: npm ci
Expand Down Expand Up @@ -402,20 +402,20 @@ jobs:
E2E_EDITOR_MODE: ${{ matrix.editor-mode }}
E2E_EVENTS_MODE: ${{ matrix.events-mode }}
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
- run: npm i -g npm@8
- uses: actions/cache@v3
- uses: actions/cache@v4
id: cache
with:
path: |
node_modules
packages/playwright-core/node_modules
~/Library/Caches/ms-playwright
key: ${{ runner.os }}-${{ runner.arch }}v${{ secrets.CACHE_VERSION }}-${{ hashFiles('package-lock.json') }}
key: ${{ runner.os }}-${{ runner.arch }}-v${{ secrets.CACHE_VERSION }}-${{ hashFiles('package-lock.json') }}
- name: Install dependencies
if: steps.cache.outputs.cache-hit != 'true'
run: npm ci
Expand Down
Loading
Loading