[build] Chore: Upgrade rollup and vite to latest versions #6018

etrepum · 2024-05-03T03:06:42Z

Description

rollup and vite have not been upgraded in some time, it makes sense to keep them up to date

Packages upgraded:

rollup (and all plugins)
vite (and all plugins)
eslint (and all plugins) - but only up to 8
- Switched from flowtype to ft-flow due to change in fb preset.
- Switched from deprecated babel-eslint to @babel/eslint-parser
docusaurus

I also upgraded most of the workflow actions because I was getting a spurious cache failure. I did not update to actions/upload-artifact@v4 which seemed like it might need some other config changes https://github.com/actions/upload-artifact?tab=readme-ov-file#breaking-changes

Other changes:

Lint fixes for the new eslint-plugin-simple-import-sort heuristics
playground's setupEnv.ts was getting tree shaken in prod because it was only performing side-effects so I refactored it and the settings panel which didn't really work correctly previously
playground now loads the dev (vercel, most tests) or prod (specific e2e tests) version of lexical from built artifacts rather than directly compiling the typescript (except when in serve mode, e.g. npm run start, so you can use hmr while developing locally)

Closes: #6012

Test plan

Before

Builds work and pass all tests

After

Builds still work and still pass all the tests

…ions

vercel · 2024-05-03T03:06:47Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
lexical	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 4, 2024 4:34am
lexical-playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 4, 2024 4:34am

ivailop7 · 2024-05-03T09:10:28Z

Thank you for doing this!

potatowagon

great work thankyou for this upgrade!

zurfyx · 2024-05-04T12:58:32Z

@ivailop7 @zurfyx one thing I noticed is that we were not currently deploying the prod build to the playground (probably after the esm refactor), but I just restored that behavior here. We were using a module resolution strategy that pointed vite directly to the typescript source files instead of the build products in dist.

I think maybe we should consider using the dev build of lexical on vercel, since it's much friendlier (in particular with regard to the tree view command history and potential error messages) and leave the prod verification to CI tasks… what do you all think? (RE #2460)

Thank you for doing this Bob! I think that's reasonable, the point of the prod build since we first introduced in the CI has always been to have some degree of certainty on a build that is slightly different than dev. We had some issues in the past with the rollup bundling that we didn't catch until it broke in prod. Currently, I think that the CI step that runs all E2E on prod already gives us this confidence so we can move on with your proposal.

zurfyx

I noticed that the port is 5173 now, I wonder how hard it is to make port 3000 back, no strong opinions though. Merging now to avoid the rebase churn.

zurfyx · 2024-05-04T13:03:26Z

scripts/npm/packages.js

@@ -1,45 +0,0 @@
-#!/usr/bin/env node


I assume this is an unrelated cleanup

Yes, this was supposed to be deleted in #5876

zurfyx · 2024-05-04T13:03:59Z

packages/lexical-utils/src/__tests__/unit/LexicalNodeHelpers.test.ts

@@ -207,7 +207,7 @@ describe('LexicalNodeHelpers tests', () => {
    test('DFS of empty ParagraphNode returns only itself', async () => {
      const editor: LexicalEditor = testEnv.editor;

-      let paragraphKey;
+      let paragraphKey: string;


Suggested change

let paragraphKey: string;

let paragraphKey: NodeKey;

honestly I only did it this way because there's a plethora of other tests that use string for keys, might be a good lint for us to find variables named /[Kk]ey$/ with a string type!

zurfyx · 2024-05-04T13:04:57Z

packages/lexical-playground/__tests__/utils/index.mjs

@@ -26,11 +36,9 @@ export const LEGACY_EVENTS = process.env.E2E_EVENTS_MODE === 'legacy-events';
 export const SAMPLE_IMAGE_URL =
  E2E_PORT === 3000
    ? '/src/images/yellow-flower.jpg'
-    : '/assets/yellow-flower.a2a7c7a2.jpg';
+    : findAsset('yellow-flower*.jpg');


So much better, finding the suffix was always time-consuming

…ite upgrade regression)

etrepum added 2 commits May 2, 2024 19:59

fix type issue from facebook#5977

6086471

chore(build) upgrade rollup, vite, and related plugins to latest vers…

f5afcb2

…ions

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 3, 2024

vercel bot had a problem deploying to Preview – lexical-playground May 3, 2024 03:08 Failure

vercel bot deployed to Preview – lexical May 3, 2024 03:08 View deployment

etrepum changed the title ~~[build] Chore: Upgrade rollup and vite to latest versions~~ [WIP] [build] Chore: Upgrade rollup and vite to latest versions May 3, 2024

etrepum added 2 commits May 3, 2024 09:40

upgrade eslint

c5910f2

use createRequire

6a00ace

vercel bot had a problem deploying to Preview – lexical-playground May 3, 2024 17:00 Failure

vercel bot deployed to Preview – lexical May 3, 2024 17:00 View deployment

commonjs & excalidraw eval

b7159dd

vercel bot deployed to Preview – lexical May 3, 2024 17:18 View deployment

vercel bot deployed to Preview – lexical-playground May 3, 2024 17:20 View deployment

Use build artifacts not typescript sources for playground build

f591d14

vercel bot had a problem deploying to Preview – lexical May 3, 2024 19:31 Failure

vercel bot deployed to Preview – lexical-playground May 3, 2024 19:32 View deployment

update docusaurus

ca1684d

vercel bot deployed to Preview – lexical May 3, 2024 19:44 View deployment

vercel bot deployed to Preview – lexical-playground May 3, 2024 19:45 View deployment

avoid shadowing globals

8bf1ec7

vercel bot deployed to Preview – lexical May 3, 2024 19:50 View deployment

vercel bot deployed to Preview – lexical-playground May 3, 2024 19:52 View deployment

explicit types for tsc

43e1adb

vercel bot deployed to Preview – lexical May 3, 2024 20:03 View deployment

vercel bot deployed to Preview – lexical-playground May 3, 2024 20:04 View deployment

unify vite module resolution

ef4e547

vercel bot deployed to Preview – lexical May 3, 2024 20:48 View deployment

vercel bot deployed to Preview – lexical-playground May 3, 2024 20:50 View deployment

module with side-effects was optimized away 🙈

c2d3246

vercel bot deployed to Preview – lexical May 3, 2024 21:39 View deployment

vercel bot deployed to Preview – lexical-playground May 3, 2024 21:40 View deployment

update actions and fix cache key inconsistency

ac22cf2

vercel bot deployed to Preview – lexical May 3, 2024 21:47 View deployment

vercel bot deployed to Preview – lexical-playground May 3, 2024 21:48 View deployment

vercel bot deployed to Preview – lexical May 3, 2024 23:44 View deployment

vercel bot deployed to Preview – lexical-playground May 3, 2024 23:45 View deployment

hard-coded hashed asset paths 😬

3f0f885

etrepum force-pushed the chore-upgrade-rollup-vite branch from c072394 to 3f0f885 Compare May 4, 2024 00:07

vercel bot deployed to Preview – lexical May 4, 2024 00:08 View deployment

vercel bot deployed to Preview – lexical-playground May 4, 2024 00:08 View deployment

that tree shaking sure is aggressive

4e4f478

vercel bot deployed to Preview – lexical-playground May 4, 2024 04:34 View deployment

vercel bot deployed to Preview – lexical May 4, 2024 04:34 View deployment

etrepum marked this pull request as ready for review May 4, 2024 05:30

etrepum requested review from zurfyx, fantactuka, acywatson, Fetz and ivailop7 as code owners May 4, 2024 05:30

etrepum changed the title ~~[WIP] [build] Chore: Upgrade rollup and vite to latest versions~~ [build] Chore: Upgrade rollup and vite to latest versions May 4, 2024

potatowagon approved these changes May 4, 2024

View reviewed changes

zurfyx approved these changes May 4, 2024

View reviewed changes

zurfyx merged commit 3e117f8 into facebook:main May 4, 2024
46 checks passed

etrepum deleted the chore-upgrade-rollup-vite branch May 4, 2024 14:58

etrepum added a commit to etrepum/lexical that referenced this pull request May 4, 2024

[playground] Bugfix: change default dev port to 3000 (facebook#6018 v…

1db16a1

…ite upgrade regression)

etrepum mentioned this pull request May 4, 2024

[playground] Bug Fix: change default dev port to 3000 #6026

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[build] Chore: Upgrade rollup and vite to latest versions #6018

[build] Chore: Upgrade rollup and vite to latest versions #6018

etrepum commented May 3, 2024 •

edited

Loading

vercel bot commented May 3, 2024 •

edited

Loading

ivailop7 commented May 3, 2024

potatowagon left a comment

zurfyx commented May 4, 2024

zurfyx left a comment

zurfyx May 4, 2024

etrepum May 4, 2024

zurfyx May 4, 2024

etrepum May 4, 2024

zurfyx May 4, 2024

[build] Chore: Upgrade rollup and vite to latest versions #6018

[build] Chore: Upgrade rollup and vite to latest versions #6018

Conversation

etrepum commented May 3, 2024 • edited Loading

Description

Test plan

Before

After

vercel bot commented May 3, 2024 • edited Loading

ivailop7 commented May 3, 2024

potatowagon left a comment

Choose a reason for hiding this comment

zurfyx commented May 4, 2024

zurfyx left a comment

Choose a reason for hiding this comment

zurfyx May 4, 2024

Choose a reason for hiding this comment

etrepum May 4, 2024

Choose a reason for hiding this comment

zurfyx May 4, 2024

Choose a reason for hiding this comment

etrepum May 4, 2024

Choose a reason for hiding this comment

zurfyx May 4, 2024

Choose a reason for hiding this comment

etrepum commented May 3, 2024 •

edited

Loading

vercel bot commented May 3, 2024 •

edited

Loading