getStyleObjectFromCSS to compute when cache miss #3024
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently offer
$getSelectionStyleValueForProperty
and$getStyleObjectFromCSS
as a way to directly access the value of the style properties they set on a TextNode.Problem is it only works when these styles are applied via @lexical/selection, lexical style changes are never taken into account.
There's 3 ways to fix this:
This PR implements 1 which is the one with the least friction and more user-friendly.
#3010