getStyleObjectFromCSS to compute when cache miss (#3024)

facebook · Nov 25, 2022 · 507794f · 507794f
1 parent ab2e08c
commit 507794f
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/packages/lexical-selection/flow/LexicalSelection.js.flow b/packages/lexical-selection/flow/LexicalSelection.js.flow
@@ -25,7 +25,7 @@ declare export function $cloneContents<T: LexicalNode>(
 declare export function $cloneWithProperties<T: LexicalNode>(node: T): T;
 declare export function getStyleObjectFromCSS(css: string): {
   [string]: string,
-} | null;
+};
 declare export function $patchStyleText(
   selection: RangeSelection | GridSelection,
   patch: {

diff --git a/packages/lexical-selection/src/index.ts b/packages/lexical-selection/src/index.ts
@@ -298,10 +298,13 @@ function $cloneContentsImpl(
   invariant(false, 'TODO');
 }
 
-export function getStyleObjectFromCSS(
-  css: string,
-): Record<string, string> | null {
-  return cssToStyles.get(css) || null;
+export function getStyleObjectFromCSS(css: string): Record<string, string> {
+  let value = cssToStyles.get(css);
+  if (value === undefined) {
+    value = getStyleObjectFromRawCSS(css);
+    cssToStyles.set(css, value);
+  }
+  return value;
 }
 
 function getStyleObjectFromRawCSS(css: string): Record<string, string> {