Remove unused exception parameter from xplat/hermes/API/hermes/cdp/Ru…

…ntimeDomainAgent.cpp

Summary:
`-Wunused-exception-parameter` has identified an unused exception parameter. This diff removes it.

This:
```
try {
    ...
} catch (exception& e) {
    // no use of e
}
```
should instead be written as
```
} catch (exception&) {
```

If the code compiles, this is safe to land.

Reviewed By: dmm-fb

Differential Revision: D60516147

fbshipit-source-id: 06d0d97ab0deb6ef8640a3f7ebebdf5e93ef9fe8

API/hermes/cdp/RuntimeDomainAgent.cpp

@@ -675,7 +675,7 @@ void RuntimeDomainAgent::callFunctionOn(
     evalResult = runtime_.evaluateJavaScript(
         std::unique_ptr<jsi::StringBuffer>(new jsi::StringBuffer(expression)),
         kEvaluatedCodeUrl);
-  } catch (const jsi::JSIException &error) {
+  } catch (const jsi::JSIException &) {
     sendResponseToClient(m::makeErrorResponse(
         req.id,
         m::ErrorCode::InternalError,
@@ -883,7 +883,7 @@ RuntimeDomainAgent::makePropsFromValue(
             desc.wasThrown = true;
             desc.value = m::runtime::makeRemoteObjectForError(
                 runtime, err.value(), *objTable_, objectGroup);
-          } catch (const jsi::JSIException &err) {
+          } catch (const jsi::JSIException &) {
             desc.wasThrown = true;
             desc.value = m::runtime::makeRemoteObject(
                 runtime,

API/hermes/inspector/chrome/CDPHandler.cpp

@@ -1711,7 +1711,7 @@ std::vector<m::runtime::PropertyDescriptor> CDPHandlerImpl::makePropsFromValue(
         jsi::Value propValue = obj.getProperty(runtime, propName);
         desc.value = m::runtime::makeRemoteObject(
             runtime, propValue, objTable_, objectGroup, false, generatePreview);
-      } catch (const jsi::JSError &err) {
+      } catch (const jsi::JSError &) {
         // We fetched a property with a getter that threw. Show a placeholder.
         // We could have added additional info, but the UI quickly gets messy.
         desc.value = m::runtime::makeRemoteObject(

API/hermes/inspector/chrome/RemoteObjectConverters.cpp

@@ -82,7 +82,7 @@ static m::runtime::ObjectPreview generateArrayPreview(
     try {
       desc = generatePropertyPreview(
           runtime, indexString, obj.getValueAtIndex(runtime, i));
-    } catch (const jsi::JSError &err) {
+    } catch (const jsi::JSError &) {
       desc.name = indexString;
       desc.type = "string";
       desc.value = "<Exception>";
@@ -121,7 +121,7 @@ static m::runtime::ObjectPreview generateObjectPreview(
       // Chrome instead detects getters and makes you click to invoke.
       desc = generatePropertyPreview(
           runtime, propName.utf8(runtime), obj.getProperty(runtime, propName));
-    } catch (const jsi::JSError &err) {
+    } catch (const jsi::JSError &) {
       desc.name = propName.utf8(runtime);
       desc.type = "string";
       desc.value = "<Exception>";

API/hermes/inspector/chrome/tests/ConnectionTests.cpp

@@ -2793,7 +2793,7 @@ TEST_F(ConnectionTests, testConsoleBuffer) {
         EXPECT_EQ(note.type, "log");
         EXPECT_EQ(note.args.size(), 1);
         received[nthLog % kExpectedMaxBufferSize] = true;
-      } catch (const std::exception &e) {
+      } catch (const std::exception &) {
         EXPECT_EQ(note.type, "warning");
         EXPECT_EQ(note.args.size(), 1);
         EXPECT_NE((*note.args[0].value).find("discarded"), std::string::npos);