Skip to content

Commit

Permalink
Remove unused exception parameter from xplat/e2ee/gecko-serializer/V1…
Browse files Browse the repository at this point in the history
…LlvSerializer.cpp

Summary:
`-Wunused-exception-parameter` has identified an unused exception parameter. This diff removes it.

This:
```
try {
    ...
} catch (exception& e) {
    // no use of e
}
```
should instead be written as
```
} catch (exception&) {
```

If the code compiles, this is safe to land.

Reviewed By: dmm-fb

Differential Revision: D60516159

fbshipit-source-id: 5e2b2f36975a47ff244ec9884d4237cf37c055dc
  • Loading branch information
r-barnes authored and facebook-github-bot committed Aug 2, 2024
1 parent 70eaf42 commit 937cde7
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions API/hermes/cdp/RemoteObjectConverters.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ static m::runtime::ObjectPreview generateArrayPreview(
try {
desc = generatePropertyPreview(
runtime, indexString, obj.getValueAtIndex(runtime, i));
} catch (const jsi::JSError &err) {
} catch (const jsi::JSError &) {
desc.name = indexString;
desc.type = "string";
desc.value = "<Exception>";
Expand Down Expand Up @@ -120,7 +120,7 @@ static m::runtime::ObjectPreview generateObjectPreview(
// Chrome instead detects getters and makes you click to invoke.
desc = generatePropertyPreview(
runtime, propName.utf8(runtime), obj.getProperty(runtime, propName));
} catch (const jsi::JSError &err) {
} catch (const jsi::JSError &) {
desc.name = propName.utf8(runtime);
desc.type = "string";
desc.value = "<Exception>";
Expand Down

0 comments on commit 937cde7

Please sign in to comment.