Fix linter errors for ./includes/fbproductfeed.php

[ajello-meta]

Description

This PR fixes phpcs issues in ./includes/fbproductfeed.php. Comments were also added for several functions. The fixes were made manually (in conjunction with ./vendor/bin/phpcbf) to ensure that the logic remains the same. Running ./vendor/bin/phpcs:

FILE: /Users/angeloou/Local Sites/test-site-i/app/public/wp-content/plugins/facebook-for-woocommerce/includes/fbproductfeed.php
--------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 48 ERRORS AND 22 WARNINGS AFFECTING 50 LINES
--------------------------------------------------------------------------------------------------------------------------------------------------
  34 | ERROR   | [ ] Missing member variable doc comment (Squiz.Commenting.VariableComment.Missing)
  35 | ERROR   | [ ] Missing member variable doc comment (Squiz.Commenting.VariableComment.Missing)
  77 | ERROR   | [x] Expected 1 spaces after opening parenthesis; 0 found (PEAR.Functions.FunctionCallSignature.SpaceAfterOpenBracket)
  77 | ERROR   | [x] Expected 1 spaces before closing parenthesis; 0 found (PEAR.Functions.FunctionCallSignature.SpaceBeforeCloseBracket)
 212 | ERROR   | [ ] Comment missing for @throws tag in function comment (Squiz.Commenting.FunctionComment.EmptyThrows)
 253 | WARNING | [ ] Variable assignment found within a condition. Did you mean to do a comparison ?
     |         |     (Generic.CodeAnalysis.AssignmentInCondition.Found)
 253 | ERROR   | [ ] Assignments must be the first block of code on a line (Squiz.PHP.DisallowMultipleAssignments.FoundInControlStructure)
 253 | WARNING | [ ] Silencing errors is strongly discouraged. Use proper error checking instead. Found: @fopen( trailingslashit(...
     |         |     (WordPress.PHP.NoSilencedErrors.Discouraged)
 253 | WARNING | [ ] File operations should use WP_Filesystem methods instead of direct PHP filesystem calls. Found: fopen().
     |         |     (WordPress.WP.AlternativeFunctions.file_system_operations_fopen)
 255 | WARNING | [ ] File operations should use WP_Filesystem methods instead of direct PHP filesystem calls. Found: fwrite().
     |         |     (WordPress.WP.AlternativeFunctions.file_system_operations_fwrite)
 256 | WARNING | [ ] File operations should use WP_Filesystem methods instead of direct PHP filesystem calls. Found: fclose().
     |         |     (WordPress.WP.AlternativeFunctions.file_system_operations_fclose)
 303 | WARNING | [ ] File operations should use WP_Filesystem methods instead of direct PHP filesystem calls. Found: fclose().
     |         |     (WordPress.WP.AlternativeFunctions.file_system_operations_fclose)
 309 | WARNING | [ ] unlink() is discouraged. Use wp_delete_file() to delete a file. (WordPress.WP.AlternativeFunctions.unlink_unlink)
 326 | WARNING | [ ] Silencing errors is strongly discouraged. Use proper error checking instead. Found: @fopen( $temp_file_path,...
     |         |     (WordPress.PHP.NoSilencedErrors.Discouraged)
 326 | WARNING | [ ] File operations should use WP_Filesystem methods instead of direct PHP filesystem calls. Found: fopen().
     |         |     (WordPress.WP.AlternativeFunctions.file_system_operations_fopen)
 329 | WARNING | [ ] File operations should use WP_Filesystem methods instead of direct PHP filesystem calls. Found: is_writable().
     |         |     (WordPress.WP.AlternativeFunctions.file_system_operations_is_writable)
 336 | WARNING | [ ] File operations should use WP_Filesystem methods instead of direct PHP filesystem calls. Found: is_writable().
     |         |     (WordPress.WP.AlternativeFunctions.file_system_operations_is_writable)
 340 | WARNING | [ ] File operations should use WP_Filesystem methods instead of direct PHP filesystem calls. Found: fwrite().
     |         |     (WordPress.WP.AlternativeFunctions.file_system_operations_fwrite)
 344 | ERROR   | [ ] Doc comment for parameter "$wp_ids" missing (Squiz.Commenting.FunctionComment.MissingParamTag)
 344 | ERROR   | [ ] Doc comment for parameter "$temp_feed_file" missing (Squiz.Commenting.FunctionComment.MissingParamTag)
 356 | WARNING | [x] Equals sign not aligned with surrounding assignments; expected 11 spaces but found 1 space
     |         |     (Generic.Formatting.MultipleStatementAlignment.NotSameWarning)
 383 | WARNING | [ ] File operations should use WP_Filesystem methods instead of direct PHP filesystem calls. Found: fwrite().
     |         |     (WordPress.WP.AlternativeFunctions.file_system_operations_fwrite)
 390 | WARNING | [ ] File operations should use WP_Filesystem methods instead of direct PHP filesystem calls. Found: fclose().
     |         |     (WordPress.WP.AlternativeFunctions.file_system_operations_fclose)
 401 | ERROR   | [ ] Missing @throws tag in function comment (Squiz.Commenting.FunctionCommentThrowTag.Missing)
 407 | WARNING | [ ] rename() is discouraged. Use WP_Filesystem::move() to rename a file. (WordPress.WP.AlternativeFunctions.rename_rename)
 419 | ERROR   | [x] Concat operator must be surrounded by a single space (Squiz.Strings.ConcatenationSpacing.PaddingFound)
 420 | ERROR   | [x] Concat operator must be surrounded by a single space (Squiz.Strings.ConcatenationSpacing.PaddingFound)
 421 | ERROR   | [x] Concat operator must be surrounded by a single space (Squiz.Strings.ConcatenationSpacing.PaddingFound)
 421 | ERROR   | [x] Space found before semicolon; expected "PHP_EOL;" but found "PHP_EOL ;" (Squiz.WhiteSpace.SemicolonSpacing.Incorrect)
 507 | WARNING | [x] Loose comparisons are not allowed. Expected: "==="; Found: "==" (Universal.Operators.StrictComparisons.LooseEqual)
 511 | WARNING | [x] Stand-alone post-increment statement found. Use pre-increment instead: ++$this->has_default_product_count.
     |         |     (Universal.Operators.DisallowStandalonePostIncrementDecrement.PostIncrementFound)
 513 | WARNING | [x] Stand-alone post-increment statement found. Use pre-increment instead: ++$this->no_default_product_count.
     |         |     (Universal.Operators.DisallowStandalonePostIncrementDecrement.PostIncrementFound)
 520 | WARNING | [x] Stand-alone post-increment statement found. Use pre-increment instead: ++$this->no_default_product_count.
     |         |     (Universal.Operators.DisallowStandalonePostIncrementDecrement.PostIncrementFound)
 551 | ERROR   | [x] Opening parenthesis of a multi-line function call must be the last content on the line
     |         |     (PEAR.Functions.FunctionCallSignature.ContentAfterOpenBracket)
 554 | ERROR   | [x] Closing parenthesis of a multi-line function call must be on a line by itself
     |         |     (PEAR.Functions.FunctionCallSignature.CloseBracketLine)
 561 | ERROR   | [ ] String concat is not required here; use a single string instead (Generic.Strings.UnnecessaryStringConcat.Found)
 562 | ERROR   | [x] Expected 1 spaces before closing parenthesis; 0 found (PEAR.Functions.FunctionCallSignature.SpaceBeforeCloseBracket)
 563 | ERROR   | [x] Expected 1 spaces before closing parenthesis; 0 found (PEAR.Functions.FunctionCallSignature.SpaceBeforeCloseBracket)
 564 | ERROR   | [x] Expected 1 spaces before closing parenthesis; 0 found (PEAR.Functions.FunctionCallSignature.SpaceBeforeCloseBracket)
 565 | ERROR   | [x] Expected 1 spaces before closing parenthesis; 0 found (PEAR.Functions.FunctionCallSignature.SpaceBeforeCloseBracket)
 566 | ERROR   | [x] Expected 1 spaces before closing parenthesis; 0 found (PEAR.Functions.FunctionCallSignature.SpaceBeforeCloseBracket)
 567 | ERROR   | [x] Expected 1 spaces before closing parenthesis; 0 found (PEAR.Functions.FunctionCallSignature.SpaceBeforeCloseBracket)
 568 | ERROR   | [x] Expected 1 spaces before closing parenthesis; 0 found (PEAR.Functions.FunctionCallSignature.SpaceBeforeCloseBracket)
 569 | ERROR   | [x] Expected 1 spaces before closing parenthesis; 0 found (PEAR.Functions.FunctionCallSignature.SpaceBeforeCloseBracket)
 570 | ERROR   | [x] Expected 1 spaces before closing parenthesis; 0 found (PEAR.Functions.FunctionCallSignature.SpaceBeforeCloseBracket)
 571 | ERROR   | [x] Expected 1 spaces before closing parenthesis; 0 found (PEAR.Functions.FunctionCallSignature.SpaceBeforeCloseBracket)
 576 | ERROR   | [x] Expected 1 spaces after opening parenthesis; 0 found (PEAR.Functions.FunctionCallSignature.SpaceAfterOpenBracket)
 576 | ERROR   | [x] Expected 1 spaces before closing parenthesis; 0 found (PEAR.Functions.FunctionCallSignature.SpaceBeforeCloseBracket)
 576 | ERROR   | [x] Concat operator must be surrounded by a single space (Squiz.Strings.ConcatenationSpacing.PaddingFound)
 576 | ERROR   | [x] Space found before semicolon; expected "PHP_EOL;" but found "PHP_EOL ;" (Squiz.WhiteSpace.SemicolonSpacing.Incorrect)
 603 | ERROR   | [x] Opening parenthesis of a multi-line function call must be the last content on the line
     |         |     (PEAR.Functions.FunctionCallSignature.ContentAfterOpenBracket)
 603 | ERROR   | [x] Expected 1 space after FUNCTION keyword; 0 found (Squiz.Functions.MultiLineFunctionDeclaration.SpaceAfterFunction)
 603 | ERROR   | [x] Expected 1 spaces after opening parenthesis; 0 found (Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingAfterOpen)
 603 | ERROR   | [x] Expected 1 spaces before closing parenthesis; 0 found
     |         |     (Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingBeforeClose)
 604 | ERROR   | [x] Expected 1 spaces after opening parenthesis; 0 found (PEAR.Functions.FunctionCallSignature.SpaceAfterOpenBracket)
 604 | ERROR   | [x] Expected 1 spaces before closing parenthesis; 0 found (PEAR.Functions.FunctionCallSignature.SpaceBeforeCloseBracket)
 605 | ERROR   | [x] Space found before comma in argument list (Generic.Functions.FunctionCallArgumentSpacing.SpaceBeforeComma)
 605 | ERROR   | [x] Only one argument is allowed per line in a multi-line function call (PEAR.Functions.FunctionCallSignature.MultipleArguments)
 605 | ERROR   | [x] Closing parenthesis of a multi-line function call must be on a line by itself
     |         |     (PEAR.Functions.FunctionCallSignature.CloseBracketLine)
 606 | ERROR   | [x] Expected 1 spaces after opening parenthesis; 0 found (PEAR.Functions.FunctionCallSignature.SpaceAfterOpenBracket)
 606 | ERROR   | [x] String "[%s]" does not require double quotes; use single quotes instead (Squiz.Strings.DoubleQuoteUsage.NotRequired)
 606 | ERROR   | [x] Expected 1 spaces before closing parenthesis; 0 found (PEAR.Functions.FunctionCallSignature.SpaceBeforeCloseBracket)
 614 | ERROR   | [x] Multi-line function declaration not indented correctly; expected 8 spaces but found 4
     |         |     (Squiz.Functions.MultiLineFunctionDeclaration.Indent)
 615 | ERROR   | [x] Multi-line function declaration not indented correctly; expected 8 spaces but found 4
     |         |     (Squiz.Functions.MultiLineFunctionDeclaration.Indent)
 616 | ERROR   | [x] Multi-line function declaration not indented correctly; expected 8 spaces but found 4
     |         |     (Squiz.Functions.MultiLineFunctionDeclaration.Indent)
 617 | ERROR   | [x] Multi-line function declaration not indented correctly; expected 8 spaces but found 4
     |         |     (Squiz.Functions.MultiLineFunctionDeclaration.Indent)
 617 | ERROR   | [x] The closing parenthesis of a multi-line function declaration must be on a new line
     |         |     (Squiz.Functions.MultiLineFunctionDeclaration.CloseBracketLine)
 669 | WARNING | [x] Equals sign not aligned with surrounding assignments; expected 15 spaces but found 1 space
     |         |     (Generic.Formatting.MultipleStatementAlignment.NotSameWarning)
 683 | ERROR   | [ ] You must use "/**" style comments for a function comment (Squiz.Commenting.FunctionComment.WrongStyle)
 683 | WARNING | [ ] It is recommended not to use reserved keyword "object" as function parameter name. Found: $object
     |         |     (Universal.NamingConventions.NoReservedKeywordParameterNames.objectFound)
--------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 45 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------------------

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Syntax change (non-breaking change which fixes code modularity, linting or phpcs issues)
• Breaking change (fix or feature that would cause existing functionality to not work as expected

Test Plan

1. Run ./vendor/bin/phpcs, you should get:

FILE: /Users/angeloou/Local Sites/test-site-i/app/public/wp-content/plugins/facebook-for-woocommerce/includes/fbproductfeed.php
--------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 12 WARNINGS AFFECTING 10 LINES
--------------------------------------------------------------------------------------------------------------------------------------------------
 253 | WARNING | Silencing errors is strongly discouraged. Use proper error checking instead. Found: @fopen( trailingslashit(...
     |         | (WordPress.PHP.NoSilencedErrors.Discouraged)
 253 | WARNING | File operations should use WP_Filesystem methods instead of direct PHP filesystem calls. Found: fopen().
     |         | (WordPress.WP.AlternativeFunctions.file_system_operations_fopen)
 255 | WARNING | File operations should use WP_Filesystem methods instead of direct PHP filesystem calls. Found: fwrite().
     |         | (WordPress.WP.AlternativeFunctions.file_system_operations_fwrite)
 256 | WARNING | File operations should use WP_Filesystem methods instead of direct PHP filesystem calls. Found: fclose().
     |         | (WordPress.WP.AlternativeFunctions.file_system_operations_fclose)
 303 | WARNING | File operations should use WP_Filesystem methods instead of direct PHP filesystem calls. Found: fclose().
     |         | (WordPress.WP.AlternativeFunctions.file_system_operations_fclose)
 326 | WARNING | Silencing errors is strongly discouraged. Use proper error checking instead. Found: @fopen( $temp_file_path,...
     |         | (WordPress.PHP.NoSilencedErrors.Discouraged)
 326 | WARNING | File operations should use WP_Filesystem methods instead of direct PHP filesystem calls. Found: fopen().
     |         | (WordPress.WP.AlternativeFunctions.file_system_operations_fopen)
 329 | WARNING | File operations should use WP_Filesystem methods instead of direct PHP filesystem calls. Found: is_writable().
     |         | (WordPress.WP.AlternativeFunctions.file_system_operations_is_writable)
 336 | WARNING | File operations should use WP_Filesystem methods instead of direct PHP filesystem calls. Found: is_writable().
     |         | (WordPress.WP.AlternativeFunctions.file_system_operations_is_writable)
 340 | WARNING | File operations should use WP_Filesystem methods instead of direct PHP filesystem calls. Found: fwrite().
     |         | (WordPress.WP.AlternativeFunctions.file_system_operations_fwrite)
 385 | WARNING | File operations should use WP_Filesystem methods instead of direct PHP filesystem calls. Found: fwrite().
     |         | (WordPress.WP.AlternativeFunctions.file_system_operations_fwrite)
 392 | WARNING | File operations should use WP_Filesystem methods instead of direct PHP filesystem calls. Found: fclose().
     |         | (WordPress.WP.AlternativeFunctions.file_system_operations_fclose)
--------------------------------------------------------------------------------------------------------------------------------------------------

2. Run extension and test the basic functionality to ensure everything still works as intended.

[github-actions]

📦 Latest Plugin Build

Built at: 2025-06-16T11:33:25.999Z
Commit: cf12ed3
Size: 1.1M

Download: Click here to download the plugin

To download: Click the link above → Scroll to bottom → Download "facebook-for-woocommerce" artifact

[facebook-github-bot]

@ajello-meta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@ajello-meta merged this pull request in 1ae81d8.