Removing exclusion of sync of excluded categories and tags by SayanPandey · Pull Request #3244 · facebook/facebook-for-woocommerce

SayanPandey · 2025-05-26T14:56:04Z

…ategories are in place

Description

This PR contains all the changes around removing exclusion of sync capability on categories and tags

Type of change

New feature

Checklist

I have commented my code, particularly in hard-to-understand areas.
I have confirmed that my changes do not introduce any new PHPCS warnings or errors.
I have checked plugin debug logs that my changes do not introduce any new PHP warnings or FATAL errors.
I followed general Pull Request best practices. Meta employees to follow this wiki.
I have added tests (if necessary) and all the new and existing unit tests pass locally with my changes.
[] I have completed dogfooding and QA testing, or I have conducted thorough due diligence to ensure that it does not break existing functionality.
[] I have updated or requested update to plugin documentations (if necessary). Meta employees to follow this wiki.

facebook-github-bot · 2025-05-26T14:56:54Z

@SayanPandey has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot · 2025-05-26T20:10:17Z

@SayanPandey has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot · 2025-05-26T21:41:41Z

@SayanPandey has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot · 2025-05-28T16:31:11Z

@SayanPandey has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot · 2025-05-29T17:56:08Z

@SayanPandey has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot · 2025-06-01T16:27:54Z

@SayanPandey has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot · 2025-06-09T12:14:48Z

@SayanPandey has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot · 2025-06-09T14:48:27Z

@SayanPandey has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot · 2025-06-10T12:49:17Z

@SayanPandey has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

…ategories are in place

facebook-github-bot · 2025-06-10T14:05:47Z

@SayanPandey has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot · 2025-06-10T14:23:01Z

@SayanPandey merged this pull request in 480dc49.

…acebook#3244)" This reverts commit 480dc49.

Summary: * Tweak - Add comprehensive unit tests for Locale class by sol-loup in #3362 * Tweak - Add unit tests for Idempotent_Request trait by sol-loup in #3380 * Tweak - Add comprehensive unit tests for MetaLog Response by sol-loup in #3376 * Tweak - Add comprehensive unit tests for ProductSets Delete Response class by sol-loup in #3398 * Fix - Since tags by sol-loup in #3397 * Tweak - Add comprehensive unit tests for Pages Read Response by sol-loup in #3378 * Tweak - Add comprehensive unit tests for User Response to improve code coverage by sol-loup in #3377 * Fix - Linter errors for ./includes/fbproductfeed.php by ajello-meta in #3396 * Tweak - Add unit tests for Events AAMSettings class by sol-loup in #3369 * Tweak - Improve CAPI event handling & add logging for Purchase events by iodic in #3360 * Fix - Adding links to the updated banner by SayanPandey in #3388 * Fix - Removing deprecated tag from Product Sync tab by SayanPandey in #3387 * Fix - Transmit opted_out_woo_all_products timestamp by vinkmeta in #3386 * Tweak - Product sync tab deprecation using Rollout Switches by SayanPandey in #3364 * Tweak - Excluded categories and tags from Rollout Switches by SayanPandey in #3382 * Tweak - Add unit tests for ProductExcludedException and ProductInvalidException by sol-loup in #3357 * Tweak - Global sync check for Rollout Switches by SayanPandey in #3367 * Fix - Limiting BatchLogHandler processing for performance reasons by vinkmeta in #3381 * Tweak - Add unit tests for Framework Api Exception class by sol-loup in #3370 * Tweak - Add unit tests for Framework Plugin Exception class by sol-loup in #3371 * Fix - Updated since tags across a few files by sol-loup in #3374 * Fix - Deprecated the concept of tip info by vinkmeta in #3373 * Fix - Removed instance of deprecated logger by vinkmeta in #3372 * Fix - the process to share ExternalVersionUpdate with Meta by vinkmeta in #3365 * Fix - Failing tests by vinkmeta in #3366 * Fix - Deprecated legacy logging apis by vinkmeta in #3351 * Fix - Issue with productSetSyncTest causing warnings during PHPUnit by sol-loup in #3355 * Tweak - Add comprehensive unit tests for Events\Normalizer class by sol-loup in #3359 * Tweak - Add unit tests for API Response classes to improve code coverage by sol-loup in #3358 * Fix - Deprecated the concept of fblog by vinkmeta in #3354 * Fix - Deprecated tool tip event concepts by vinkmeta in #3349 * Fix - Removed unnecessary logs being sent to Meta servers by vinkmeta in #3347 * Fix - Clean up info Banner releated class and components by vinkmeta in #3348 * Fix - Sending backgroung syncing jobs action logs to Meta by vinkmeta in #3346 * Fix - Tracking error messages being displayed to Admins by vinkmeta in #3345 * Tweak - Workflow for Releasing Plugin by tzahgr in #3309 * Fix - Deleted wp_ajax_ajax_sync_all_fb_products action by vinkmeta in #3343 * Fix - Deprecated log_with_debug_mode_enabled by vinkmeta in #3342 * Fix - Removed unnecessary logs by vinkmeta in #3341 * Fix - removing duplicate logging by vinkmeta in #3337 * Fix - Updated exception logs to centralized logger by vinkmeta in #3338 * Fix - Migrated Feed Logger by vinkmeta in #3340 * Fix - Deprecated log_to_meta functionality by vinkmeta in #3336 * Fix - Enabled fbproduct for code sniffing in #3328 * Fix - Enabled phpcs for plugin banners by vinkmeta in #3332 * Fix - Updated loggers for Feeds by vinkmeta in #3335 * Fix - Updated loggers for checkout flow by vinkmeta in #3334 * Fix - Logging background product syncing debug logs by vinkmeta in #3329 * Fix - Enabled Pixel Normalizer for CS by vinkmeta in #3333 * Fix - Update to Feed Loggers by vinkmeta in #3330 * Fix - Debug logs for background product syncing by vinkmeta in #3327 * Add - Sync all products if user has opted-in for Woo All Products by SayanPandey in #3281 * Fix - PHPUnit warnings by renaming test files to match their class names by sol-loup in #3311 * Tweak - Removing exclusion of sync of excluded categories and tags by SayanPandey in #3244 * Fix - Lints and phpcs issues with fbproduct by vinkmeta in #3324 * Fix - Code sniffing fixes for fbproduct by vinkmeta in #3323 * Fix - Migrated Product Feed Progress Logging Mechanism by vinkmeta in #3321 * Fix - Added critical log when user attempting non-permissible actions by vinkmeta in #3322 * Fix - Handling edge case with BatchLogHandler in #3320 * Fix - Product Group Logging by vinkmeta in #3317 * Fix - PHPCBF for fbproduct by vinkmeta in #3319 * Fix - Linting for WC_Facebookcommerce_Background_Process by vinkmeta in #3318 * Tweak - Adding tags on excluded categories and tags by SayanPandey in #3308 * Tweak - Removing unnecessary modal for excluded categories by SayanPandey in #3307 * Tweak - Removing delete on stock check by SayanPandey in #3306 * Add - Showing a banner to the user about the changes by SayanPandey in #3256 * Fix - Updated location for Product Feeds by vinkmeta in #3316 * Tweak - Removing internal wiki links by vinkmeta in #3315 * Add - Introducing a centralized logger by vinkmeta in #3313 * Fix - Update ratings and reviews query logic and fix tests by nrostrow-meta in #3312 * Fix - Restoring the product sync tagging with integers by SayanPandey in #3305 * Tweak - Removing Enable Sync checkbox by SayanPandey in #3241 * Fix - Flush rewrite rules to ensure /fb-checkout endpoint is working correctly by ajello-meta in #3301 * Tweak - Deprecating Product Sync tab by SayanPandey in #3273 * Tweak - Updated GitHub PR template by vinkmeta in #3304 * Fix - Changed json_encode to wp_json_encode to avoid phpcs issues by vinkmeta in #3303 * Fix - Replaced json_encode with wp_json_encode by vinkmeta in #3276 * Fix - Linting issues resolved for includes/ProductSets/Sync.phpby sol-loup in #3188 * Fix - Linting issues resolved for includes/Utilities/Background_Remove_Duplicate_Visibility_Meta.php by sol-loup in #3187 * Fix - Linting issues resolved for includes/Events/Event.php by sol-loup in #3189 * Tweak - Enable Video sync at Variable Product Level by gurtejrehal in #3291 * Fix - Revert #3295 by vinkmeta in #3299 Pull Request resolved: #3444 Reviewed By: tzahgr Differential Revision: D77219857 Pulled By: vahidkay-meta fbshipit-source-id: 52148818ea2d6c1b937f3caa78e6071a258d17f3

facebook-github-bot added the CLA Signed label May 26, 2025

SayanPandey force-pushed the RemovingExcludingCategoriesAndTags branch 2 times, most recently from 3fa1972 to fa5f99b Compare May 27, 2025 18:52

SayanPandey force-pushed the RemovingExcludingCategoriesAndTags branch 2 times, most recently from 9bfa5f2 to 7c14b67 Compare May 28, 2025 22:19

SayanPandey changed the title ~~Removing exclusion of sync of excluded categories~~ Removing exclusion of sync of excluded categories and tags May 28, 2025

SayanPandey force-pushed the RemovingExcludingCategoriesAndTags branch from 6d6087f to da2b317 Compare May 29, 2025 16:56

SayanPandey force-pushed the RemovingExcludingCategoriesAndTags branch from 08f80c5 to ceb5218 Compare June 1, 2025 16:26

SayanPandey force-pushed the RemovingExcludingCategoriesAndTags branch from ceb5218 to 30e3e01 Compare June 9, 2025 12:04

SayanPandey force-pushed the RemovingExcludingCategoriesAndTags branch 2 times, most recently from d182b6a to f260e20 Compare June 10, 2025 12:37

SayanPandey added 10 commits June 10, 2025 14:33

Adding plugin version logic

88a5954

Adding a dummy banner

a0209a5

Adding custom action to link JS to PHP code

1e724d8

Moving the add actions to addHooks()

325b81d

registering new plugin update script

695f4b9

Adding functional back and forth js-php connection vaia ajax url

94e1472

Addin opt out and opt in banner with refresh

67606f8

Finalizing the opt out experience except the links and proper version

9039db3

Adding opt out approach

00d3238

Adding phpcs fix

512072f

SayanPandey added 21 commits June 10, 2025 14:33

Added the modal

cb42f6a

Adding phpcs fixes

1a8427e

Adding phpcs fixes

a1335af

Fixing plugin diff comments

5467c03

Removing plugin upgrade code

08292e9

Adding timeout on banner close

99b0fdf

Making phpcs fixes

dd17a54

Renaming plugin update to plugin rendering js

1583285

Renaming it to PluginUpdate.php

668c7b9

making the latest changes with all renaming

7982bca

Fixing diff comments

68c0ed0

Adding test fixes

2a00a9c

Fixing diff comments

c189680

Removing bulk action validation, dead code and toggle when excluded c…

3dc856a

…ategories are in place

Removing all the useless product exclusion and stock related stuff

a2d9ba0

Nullifying excluded categories and taga

f5b6412

Resolving all the tests based on excluded categories and tags

48ccfa4

Removing a space to activate the rebase

a5abf90

Adding some phpcs fixes

2879446

Removing the code that disables the commerce settings

45b7451

Fixing diff comments 2

8650132

SayanPandey force-pushed the RemovingExcludingCategoriesAndTags branch from f260e20 to 8650132 Compare June 10, 2025 13:36

facebook-github-bot closed this in 480dc49 Jun 10, 2025

facebook-github-bot added the Merged label Jun 10, 2025

SayanPandey added a commit to SayanPandey/facebook-for-woocommerce that referenced this pull request Jun 13, 2025

Revert "Removing exclusion of sync of excluded categories and tags (f…

c4685f9

…acebook#3244)" This reverts commit 480dc49.

vahidkay-meta mentioned this pull request Jun 20, 2025

Release/3.5.3 #3444

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Removing exclusion of sync of excluded categories and tags#3244

Removing exclusion of sync of excluded categories and tags#3244
SayanPandey wants to merge 36 commits intofacebook:mainfrom
SayanPandey:RemovingExcludingCategoriesAndTags

SayanPandey commented May 26, 2025

Uh oh!

facebook-github-bot commented May 26, 2025

Uh oh!

facebook-github-bot commented May 26, 2025

Uh oh!

facebook-github-bot commented May 26, 2025

Uh oh!

facebook-github-bot commented May 28, 2025

Uh oh!

facebook-github-bot commented May 29, 2025

Uh oh!

facebook-github-bot commented Jun 1, 2025

Uh oh!

facebook-github-bot commented Jun 9, 2025

Uh oh!

facebook-github-bot commented Jun 9, 2025

Uh oh!

facebook-github-bot commented Jun 10, 2025

Uh oh!

facebook-github-bot commented Jun 10, 2025

Uh oh!

facebook-github-bot commented Jun 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

SayanPandey commented May 26, 2025

Description

Type of change

Checklist

Uh oh!

facebook-github-bot commented May 26, 2025

Uh oh!

facebook-github-bot commented May 26, 2025

Uh oh!

facebook-github-bot commented May 26, 2025

Uh oh!

facebook-github-bot commented May 28, 2025

Uh oh!

facebook-github-bot commented May 29, 2025

Uh oh!

facebook-github-bot commented Jun 1, 2025

Uh oh!

facebook-github-bot commented Jun 9, 2025

Uh oh!

facebook-github-bot commented Jun 9, 2025

Uh oh!

facebook-github-bot commented Jun 10, 2025

Uh oh!

facebook-github-bot commented Jun 10, 2025

Uh oh!

facebook-github-bot commented Jun 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants