Conversation
jczhuoMeta
left a comment
jczhuoMeta
left a comment
There was a problem hiding this comment.
Overall looks to me.
Ping me when you double check the comment. I will go ahead approve it.
| @@ -15,7 +14,7 @@ | |||
| use WooCommerce\Facebook\Framework\Helper; | |||
| use Automattic\WooCommerce\Utilities\OrderUtil; | |||
|
|
|||
There was a problem hiding this comment.
Maybe use WC_Facebookcommerce here?
| [ 'jquery', 'select2' ], | ||
| \WC_Facebookcommerce::PLUGIN_VERSION, | ||
| true | ||
| false |
There was a problem hiding this comment.
Want to make sure this is intentional as the description reads only format change
|
@sol-loup has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@sol-loup has updated the pull request. You must reimport the pull request before landing. |
|
@sol-loup has updated the pull request. You must reimport the pull request before landing. |
|
@sol-loup has updated the pull request. You must reimport the pull request before landing. |
|
@sol-loup has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@sol-loup has updated the pull request. You must reimport the pull request before landing. |
|
@sol-loup has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
3 participants
Changes proposed in this Pull Request:
Closes # .
Replace this with a good description of your changes & reasoning.
phpcschecks? Please removephpcs:ignorecomments in changed files and fix any issues, or delete if not practical.Screenshots:
Detailed test instructions:
Additional details:
Changelog entry