Closed
Conversation
Contributor
|
@vahidkay-meta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@vahidkay-meta merged this pull request in 9c06d5c. |
This was referenced Mar 4, 2025
Closed
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 11, 2025
Summary: - phpcs fixes 1 (#2897) - Release/3.4.1 (#2911) - Lightly refactoring Admin.php to make it compliant with WooC linter. - Adding todo for meta_query ### Changes proposed in this Pull Request: Closes # . _Replace this with a good description of your changes & reasoning._ - [ ] Do the changed files pass `phpcs` checks? Please remove `phpcs:ignore` comments in changed files and fix any issues, or delete if not practical. ### Screenshots: ### Detailed test instructions: 1. 2. 3. ### Additional details: <!-- Optional. Enter a summary of all changes in this Pull Request, which will be added to the changelog if accepted. Each line should start with change type prefix`(Fix|Add|…) - `, for example: > Break - A change breaking previous API or functionality. > Add - A new feature, function or functionality was added. > Update - Big changes to something that wasn't broken. > Fix - Took care of something that wasn't working. > Tweak - Small change, that isn't actually very important. > Dev - Developer-facing only change. > Doc - Updated customer or developer facing documentation If you remove the "Changelog entry" header, the Pull Request title will be used as the changelog entry. Add the `changelog: none` label if no changelog entry is needed. --> ### Changelog entry > Pull Request resolved: #2919 Test Plan: Imported from GitHub, without a `Test Plan:` line. **!---- (auto-generated) DO NOT EDIT OR PUT ANYTHING AFTER THIS LINE ----!** MFTRunTestsScript Run / Test Suite: sa_checkout / Test Collection: bloks / Diff Version V3 https://internalfb.com/intern/testinfra/testrun/16888498674860108 MFTRunTestsScript Run / Test Suite: sa_checkout / Test Collection: www / Diff Version V3 https://internalfb.com/intern/testinfra/testrun/1970325109499345 Reviewed By: jczhuoMeta Differential Revision: D70652191 Pulled By: sol-loup fbshipit-source-id: 9ceb9269a4a458f88569105b82a3aea925844522
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog entry