Skip to content

Use ::class for classname resolution (#2357) #2359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ibndawood merged 1 commit into from
Nov 7, 2022
Merged

Use ::class for classname resolution (#2357) #2359

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions class-wc-facebookcommerce.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
use SkyVerge\WooCommerce\Facebook\Utilities\Heartbeat;
use Automattic\WooCommerce\Admin\Features\Features as WooAdminFeatures;
use Automattic\WooCommerce\Admin\Features\OnboardingTasks\TaskLists;
use Automattic\WooCommerce\Admin\Notes\Note;
use SkyVerge\WooCommerce\Facebook\Admin\Tasks\Setup;
use SkyVerge\WooCommerce\Facebook\Admin\Notes\SettingsMoved;

Expand Down Expand Up @@ -262,7 +263,7 @@ protected function get_deprecated_hooks() {
* @since x.x.x
*/
public function add_setup_task() {
if ( class_exists( 'TaskLists' ) ) { // This is added for backward compatibility.
if ( class_exists( TaskLists::class ) ) { // This is added for backward compatibility.
TaskLists::add_task(
'extended',
new Setup(
Expand Down Expand Up @@ -386,7 +387,7 @@ public function add_admin_notices() {
&& \Automattic\WooCommerce\Admin\Loader::is_feature_enabled( 'marketing' );
}

if ( $is_marketing_enabled && class_exists( '\Automattic\WooCommerce\Admin\Notes\Note' ) ) { // Checking for Note class is for backward compatibility.
if ( $is_marketing_enabled && class_exists( Note::class ) ) { // Checking for Note class is for backward compatibility.
SettingsMoved::possibly_add_or_delete_note();
}
}
Expand Down