Skip to content

Use ::class for classname resolution (#2357)#2359

Merged
ibndawood merged 1 commit intodevelopfrom
fix/2357-classname-resolution
Nov 7, 2022
Merged

Use ::class for classname resolution (#2357)#2359
ibndawood merged 1 commit intodevelopfrom
fix/2357-classname-resolution

Conversation

@ibndawood
Copy link
Copy Markdown
Contributor

Changes proposed in this Pull Request:

Uses ::class to resolve a classname for class_exists check.

  • Do the changed files pass phpcs checks? Please remove phpcs:ignore comments in changed files and fix any issues, or delete if not practical.

@ibndawood ibndawood requested a review from a team November 7, 2022 14:35
@github-actions github-actions bot added changelog: fix Took care of something that wasn't working. type: bug The issue is a confirmed bug. labels Nov 7, 2022
@ibndawood ibndawood added changelog: none Skip changelog entry for this PR and removed type: bug The issue is a confirmed bug. changelog: fix Took care of something that wasn't working. labels Nov 7, 2022
Copy link
Copy Markdown
Contributor

@JPry JPry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@ibndawood ibndawood self-assigned this Nov 7, 2022
@ibndawood ibndawood merged commit 728dba8 into develop Nov 7, 2022
@ibndawood ibndawood deleted the fix/2357-classname-resolution branch November 7, 2022 14:37
@ibndawood
Copy link
Copy Markdown
Contributor Author

Thank you @JPry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: none Skip changelog entry for this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants