Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme): fix DocsVersionDropdownNavbarItem version link target #10288

Merged
merged 2 commits into from
Jul 10, 2024

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Jul 10, 2024

Motivation

Fix #10206

This ensures that the version dropdown "button" and the list item element are consistent and link to the same URL (the current doc, in that version)

CleanShot 2024-07-10 at 17 37 37

Previously, the "button" would link to the root of the docs while the list item would link to the doc.

Test Plan

preview

Test links

https://deploy-preview-10288--docusaurus-2.netlify.app/

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Jul 10, 2024
@slorber slorber requested a review from Josh-Cena as a code owner July 10, 2024 15:39
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jul 10, 2024
Copy link

netlify bot commented Jul 10, 2024

[V2]

Name Link
🔨 Latest commit 494fb8e
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/668eaca339e3f7000898247b
😎 Deploy Preview https://deploy-preview-10288--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO Report
/ 🔴 39 🟢 98 🟢 100 🟢 100 Report
/docs/installation 🟠 69 🟢 97 🟢 100 🟢 100 Report
/docs/category/getting-started 🟠 75 🟢 100 🟢 100 🟠 86 Report
/blog 🟠 68 🟢 100 🟢 100 🟠 86 Report
/blog/preparing-your-site-for-docusaurus-v3 🔴 48 🟢 96 🟢 100 🟢 100 Report
/blog/tags/release 🟠 70 🟢 100 🟢 100 🟠 86 Report
/blog/tags 🟠 74 🟢 100 🟢 100 🟠 86 Report

@slorber slorber merged commit 8b877d2 into main Jul 10, 2024
4 checks passed
@slorber slorber deleted the slorber/fix-version-dropdown-button-link branch July 10, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clicking "current version" at the version dropdown redirects to the landing page of docs, which is unintuitive
2 participants